diff options
| -rw-r--r-- | src/library/coverart.h | 2 | ||||
| -rw-r--r-- | src/library/coverartcache.cpp | 4 | ||||
| -rw-r--r-- | src/library/coverartdelegate.cpp | 1 |
3 files changed, 4 insertions, 3 deletions
diff --git a/src/library/coverart.h b/src/library/coverart.h index 6599f99c4b..bdbb68d8fc 100644 --- a/src/library/coverart.h +++ b/src/library/coverart.h @@ -48,7 +48,7 @@ struct CoverInfo { Source source; Type type; - QString coverLocation; // Reative path, starting from trackLocation + QString coverLocation; // Relative path, starting from trackLocation QString trackLocation; quint16 hash; }; diff --git a/src/library/coverartcache.cpp b/src/library/coverartcache.cpp index c8ac3937ca..a7d938aeec 100644 --- a/src/library/coverartcache.cpp +++ b/src/library/coverartcache.cpp @@ -118,7 +118,9 @@ void CoverArtCache::requestCover(const Track* pTrack, if (pCache == nullptr || pTrack == nullptr) return; CoverInfo info = pTrack->getCoverInfo(); - // trackLocation is still empty here + // trackLocation can be still empty here + // TODO(DSC) it is an design issue that we have + // redundant trackLocation info here info.trackLocation = pTrack->getLocation(); pCache->requestCover(info, pRequestor, 0, false, true); } diff --git a/src/library/coverartdelegate.cpp b/src/library/coverartdelegate.cpp index 13027da4cb..d93639d62d 100644 --- a/src/library/coverartdelegate.cpp +++ b/src/library/coverartdelegate.cpp @@ -71,7 +71,6 @@ void CoverArtDelegate::slotOnlyCachedCoverArt(bool b) { void CoverArtDelegate::slotCoverFound(const QObject* pRequestor, const CoverInfo& info, QPixmap pixmap, bool fromCache) { - Q_UNUSED(info); if (pRequestor == this && !pixmap.isNull() && !fromCache) { // qDebug() << "CoverArtDelegate::slotCoverFound" << pRequestor << info // << pixmap.size(); |