diff options
| author | Uwe Klotz <uklotz@mixxx.org> | 2020-12-11 22:26:14 +0100 |
|---|---|---|
| committer | Uwe Klotz <uklotz@mixxx.org> | 2020-12-11 22:26:14 +0100 |
| commit | e81fddcf56f5cf7473dba3f0ee514f618c64c9a3 (patch) | |
| tree | e455bc2267f1f479973d95de12556fd618f17fe6 /src | |
| parent | eb554ca891467f12d74451bf10fb6ba980057f98 (diff) | |
Fix shadowing of variable names
Diffstat (limited to 'src')
| -rw-r--r-- | src/musicbrainz/musicbrainzxml.cpp | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/src/musicbrainz/musicbrainzxml.cpp b/src/musicbrainz/musicbrainzxml.cpp index 9a515b4f98..ee440e69d5 100644 --- a/src/musicbrainz/musicbrainzxml.cpp +++ b/src/musicbrainz/musicbrainzxml.cpp @@ -379,24 +379,22 @@ QPair<QList<TrackRelease>, bool> readElementRecording(QXmlStreamReader& reader) while (continueReading(reader)) { const QXmlStreamReader::TokenType type = reader.readNext(); if (type == QXmlStreamReader::StartElement) { - const QStringRef name = reader.name(); - if (name == QLatin1String("title")) { + if (reader.name() == QLatin1String("title")) { DEBUG_ASSERT(recordingTitle.isNull()); recordingTitle = reader.readElementText(); - } else if (name == QLatin1String("length")) { + } else if (reader.name() == QLatin1String("length")) { DEBUG_ASSERT(recordingDuration == Duration::empty()); parseDuration(reader.readElementText(), &recordingDuration); - } else if (name == QLatin1String("artist-credit")) { + } else if (reader.name() == QLatin1String("artist-credit")) { readElementArtistCredit(reader, recordingArtist, recordingArtistId); - } else if (name == QLatin1String("release-list")) { + } else if (reader.name() == QLatin1String("release-list")) { // Consume release-list while (continueReading(reader)) { const QXmlStreamReader::TokenType type = reader.readNext(); if (type == QXmlStreamReader::StartElement) { - const QStringRef name = reader.name(); - if (name == QLatin1String("release")) { + if (reader.name() == QLatin1String("release")) { trackReleases.append(readElementRelease(reader)); - } else if (name == QLatin1String("release-group")) { + } else if (reader.name() == QLatin1String("release-group")) { DEBUG_ASSERT(releaseGroupId.isNull()); releaseGroupId = QUuid(reader.attributes().value(QStringLiteral("id")).toString()); DEBUG_ASSERT(!releaseGroupId.isNull()); @@ -456,11 +454,10 @@ Error::Error( : Error() { while (continueReading(reader)) { if (reader.readNext() == QXmlStreamReader::StartElement) { - const QStringRef name = reader.name(); - if (name == QLatin1String("message")) { + if (reader.name() == QLatin1String("message")) { DEBUG_ASSERT(message == Error().message); message = reader.readElementText(); - } else if (name == QLatin1String("code")) { + } else if (reader.name() == QLatin1String("code")) { DEBUG_ASSERT(code == Error().code); bool ok; int val = reader.readElementText().toInt(&ok); |