summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorBe <be@mixxx.org>2020-12-07 18:21:39 -0600
committerBe <be@mixxx.org>2020-12-07 18:22:34 -0600
commitb17498c9c7b40560de7ca27783032bf49f5113a7 (patch)
treec289fe350995eea0aee07ce0a1f54480bb2aa8a0 /src
parente0f70a2cc1d10b65f5b7cf5bd832121510e66a11 (diff)
set default waveform renderer to RGB (non-GL) for macOS
Diffstat (limited to 'src')
-rw-r--r--src/waveform/waveformwidgetfactory.cpp7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/waveform/waveformwidgetfactory.cpp b/src/waveform/waveformwidgetfactory.cpp
index 355f08ad60..6c26009b56 100644
--- a/src/waveform/waveformwidgetfactory.cpp
+++ b/src/waveform/waveformwidgetfactory.cpp
@@ -734,7 +734,9 @@ void WaveformWidgetFactory::swap() {
}
WaveformWidgetType::Type WaveformWidgetFactory::autoChooseWidgetType() const {
- //default selection
+ // OpenGL waveform performance is bad on macOS with QGLWidget and Qt 5.
+ // TODO: remove this #ifndef when upgrading to QOpenGLWidget
+#ifndef __APPLE__
if (m_openGlAvailable) {
if (m_openGLShaderAvailable) {
return WaveformWidgetType::GLSLRGBWaveform;
@@ -742,7 +744,8 @@ WaveformWidgetType::Type WaveformWidgetFactory::autoChooseWidgetType() const {
return WaveformWidgetType::GLRGBWaveform;
}
}
- return WaveformWidgetType::SoftwareWaveform;
+#endif
+ return WaveformWidgetType::RGBWaveform;
}
void WaveformWidgetFactory::evaluateWidgets() {