summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorUwe Klotz <uklotz@mixxx.org>2020-12-09 08:43:48 +0100
committerGitHub <noreply@github.com>2020-12-09 08:43:48 +0100
commita0baffe0d04cc91fe5b7486bd5686f45df994862 (patch)
treeb9a7dad50b79058ffa86aa228ee595cee145d5a7 /src
parent3804c3f5dcfcc80578b4d9a6287ac99aa84f2706 (diff)
parent9b36f9a04c86a9afc6f2fcda108d2b71b2a62c36 (diff)
Merge pull request #3419 from uklotzde/basetracktablemodel
Fix crash when accessing invalid/unknown track table column
Diffstat (limited to 'src')
-rw-r--r--src/library/basetracktablemodel.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/library/basetracktablemodel.cpp b/src/library/basetracktablemodel.cpp
index b7881f23c6..ba8ae4c6db 100644
--- a/src/library/basetracktablemodel.cpp
+++ b/src/library/basetracktablemodel.cpp
@@ -451,7 +451,11 @@ QVariant BaseTrackTableModel::rawSiblingValue(
return QVariant();
}
const auto siblingColumn = fieldIndex(siblingField);
- DEBUG_ASSERT(siblingColumn >= 0);
+ if (siblingColumn < 0) {
+ // Unsupported or unknown column/field
+ // FIXME: This should never happen but it does. But why??
+ return QVariant();
+ }
VERIFY_OR_DEBUG_ASSERT(siblingColumn != index.column()) {
// Prevent infinite recursion
return QVariant();