summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorJan Holthuis <jan.holthuis@ruhr-uni-bochum.de>2020-03-01 09:22:24 +0100
committerJan Holthuis <jan.holthuis@ruhr-uni-bochum.de>2020-03-01 09:22:24 +0100
commit26f8c3bb84c4afa20898c320f9b65577076d88f6 (patch)
tree4d414351166b1aa2337aa3e3efa2d74f7db1d9b2 /src
parentb8ee8d656a2591f212411cac29da1ad6faf33ad9 (diff)
Remove unnecessary const from (optional) RgbColor parameters
Diffstat (limited to 'src')
-rw-r--r--src/engine/controls/cuecontrol.cpp2
-rw-r--r--src/engine/controls/cuecontrol.h2
-rw-r--r--src/track/cue.cpp2
-rw-r--r--src/track/cue.h2
-rw-r--r--src/widget/wcolorpicker.cpp6
-rw-r--r--src/widget/wcolorpicker.h6
-rw-r--r--src/widget/wcuemenupopup.cpp2
-rw-r--r--src/widget/wcuemenupopup.h2
-rw-r--r--src/widget/wtracktableview.cpp2
-rw-r--r--src/widget/wtracktableview.h2
10 files changed, 14 insertions, 14 deletions
diff --git a/src/engine/controls/cuecontrol.cpp b/src/engine/controls/cuecontrol.cpp
index d3a53229ea..f7255059e8 100644
--- a/src/engine/controls/cuecontrol.cpp
+++ b/src/engine/controls/cuecontrol.cpp
@@ -1904,7 +1904,7 @@ mixxx::RgbColor::optional_t HotcueControl::getColor() const {
return doubleToRgbColor(m_hotcueColor->get());
}
-void HotcueControl::setColor(const mixxx::RgbColor::optional_t newColor) {
+void HotcueControl::setColor(mixxx::RgbColor::optional_t newColor) {
if (!newColor) {
m_hotcueColor->set(kNoColorControlValue);
return;
diff --git a/src/engine/controls/cuecontrol.h b/src/engine/controls/cuecontrol.h
index ecc071e97f..4c9f0e32a7 100644
--- a/src/engine/controls/cuecontrol.h
+++ b/src/engine/controls/cuecontrol.h
@@ -51,7 +51,7 @@ class HotcueControl : public QObject {
void setCue(CuePointer pCue);
void resetCue();
void setPosition(double position);
- void setColor(const mixxx::RgbColor::optional_t newColor);
+ void setColor(mixxx::RgbColor::optional_t newColor);
mixxx::RgbColor::optional_t getColor() const;
// Used for caching the preview state of this hotcue control.
diff --git a/src/track/cue.cpp b/src/track/cue.cpp
index d7bc86e8fa..57406665e8 100644
--- a/src/track/cue.cpp
+++ b/src/track/cue.cpp
@@ -165,7 +165,7 @@ mixxx::RgbColor Cue::getColor() const {
return m_color;
}
-void Cue::setColor(const mixxx::RgbColor color) {
+void Cue::setColor(mixxx::RgbColor color) {
QMutexLocker lock(&m_mutex);
m_color = color;
m_bDirty = true;
diff --git a/src/track/cue.h b/src/track/cue.h
index 6846041b70..34631127fa 100644
--- a/src/track/cue.h
+++ b/src/track/cue.h
@@ -55,7 +55,7 @@ class Cue : public QObject {
void setLabel(QString label);
mixxx::RgbColor getColor() const;
- void setColor(const mixxx::RgbColor color);
+ void setColor(mixxx::RgbColor color);
double getEndPosition() const;
diff --git a/src/widget/wcolorpicker.cpp b/src/widget/wcolorpicker.cpp
index a2ba6d8d9c..a1adc31ae9 100644
--- a/src/widget/wcolorpicker.cpp
+++ b/src/widget/wcolorpicker.cpp
@@ -79,7 +79,7 @@ WColorPicker::WColorPicker(ColorOption colorOption, const ColorPalette& palette,
}
}
-void WColorPicker::addColorButton(const mixxx::RgbColor::optional_t color, QGridLayout* pLayout, int row, int column) {
+void WColorPicker::addColorButton(mixxx::RgbColor::optional_t color, QGridLayout* pLayout, int row, int column) {
setLayout(pLayout);
parented_ptr<QPushButton> pColorButton = make_parented<QPushButton>("", this);
if (m_pStyle) {
@@ -142,7 +142,7 @@ void WColorPicker::resetSelectedColor() {
pButton->style()->polish(pButton);
}
-void WColorPicker::setSelectedColor(const mixxx::RgbColor::optional_t color) {
+void WColorPicker::setSelectedColor(mixxx::RgbColor::optional_t color) {
resetSelectedColor();
m_selectedColor = color;
@@ -196,6 +196,6 @@ void WColorPicker::useColorSet(const ColorPalette& palette) {
}
}
-void WColorPicker::slotColorPicked(const mixxx::RgbColor::optional_t color) {
+void WColorPicker::slotColorPicked(mixxx::RgbColor::optional_t color) {
setSelectedColor(color);
}
diff --git a/src/widget/wcolorpicker.h b/src/widget/wcolorpicker.h
index 671be786b0..8c744c1385 100644
--- a/src/widget/wcolorpicker.h
+++ b/src/widget/wcolorpicker.h
@@ -20,17 +20,17 @@ class WColorPicker : public QWidget {
explicit WColorPicker(ColorOption colorOption, const ColorPalette& palette, QWidget* parent = nullptr);
void resetSelectedColor();
- void setSelectedColor(const mixxx::RgbColor::optional_t color);
+ void setSelectedColor(mixxx::RgbColor::optional_t color);
void useColorSet(const ColorPalette& palette);
signals:
void colorPicked(mixxx::RgbColor::optional_t color);
private slots:
- void slotColorPicked(const mixxx::RgbColor::optional_t color);
+ void slotColorPicked(mixxx::RgbColor::optional_t color);
private:
- void addColorButton(const mixxx::RgbColor::optional_t color, QGridLayout* pLayout, int row, int column);
+ void addColorButton(mixxx::RgbColor::optional_t color, QGridLayout* pLayout, int row, int column);
ColorOption m_colorOption;
mixxx::RgbColor::optional_t m_selectedColor;
ColorPalette m_palette;
diff --git a/src/widget/wcuemenupopup.cpp b/src/widget/wcuemenupopup.cpp
index 0d21dcdc8e..0ab8f54ac4 100644
--- a/src/widget/wcuemenupopup.cpp
+++ b/src/widget/wcuemenupopup.cpp
@@ -110,7 +110,7 @@ void WCueMenuPopup::slotEditLabel() {
m_pCue->setLabel(m_pEditLabel->text());
}
-void WCueMenuPopup::slotChangeCueColor(const mixxx::RgbColor::optional_t color) {
+void WCueMenuPopup::slotChangeCueColor(mixxx::RgbColor::optional_t color) {
VERIFY_OR_DEBUG_ASSERT(m_pCue != nullptr) {
return;
}
diff --git a/src/widget/wcuemenupopup.h b/src/widget/wcuemenupopup.h
index e052b948de..3c8094e8be 100644
--- a/src/widget/wcuemenupopup.h
+++ b/src/widget/wcuemenupopup.h
@@ -54,7 +54,7 @@ class WCueMenuPopup : public QWidget {
private slots:
void slotEditLabel();
void slotDeleteCue();
- void slotChangeCueColor(const mixxx::RgbColor::optional_t color);
+ void slotChangeCueColor(mixxx::RgbColor::optional_t color);
private:
CuePointer m_pCue;
diff --git a/src/widget/wtracktableview.cpp b/src/widget/wtracktableview.cpp
index 562658d860..11791c1acb 100644
--- a/src/widget/wtracktableview.cpp
+++ b/src/widget/wtracktableview.cpp
@@ -1972,7 +1972,7 @@ void WTrackTableView::lockBpm(bool lock) {
}
}
-void WTrackTableView::slotColorPicked(const mixxx::RgbColor::optional_t color) {
+void WTrackTableView::slotColorPicked(mixxx::RgbColor::optional_t color) {
TrackModel* trackModel = getTrackModel();
if (trackModel == nullptr) {
return;
diff --git a/src/widget/wtracktableview.h b/src/widget/wtracktableview.h
index 03cb8c3cf3..fd6beae9d6 100644
--- a/src/widget/wtracktableview.h
+++ b/src/widget/wtracktableview.h
@@ -81,7 +81,7 @@ class WTrackTableView : public WLibraryTableView {
void slotLockBpm();
void slotUnlockBpm();
void slotScaleBpm(int);
- void slotColorPicked(const mixxx::RgbColor::optional_t color);
+ void slotColorPicked(mixxx::RgbColor::optional_t color);
void slotClearBeats();
void slotClearPlayCount();