Fix undefined behavior warning for QPointer upon deletion

2 files changed, 8 insertions, 2 deletions

diff --git a/src/widget/wtrackmenu.cpp b/src/widget/wtrackmenu.cpp
index 969f43f8d9..4312ca939b 100644
--- a/src/widget/wtrackmenu.cpp
+++ b/src/widget/wtrackmenu.cpp
@@ -60,6 +60,13 @@ WTrackMenu::WTrackMenu(QWidget* parent,
     setupActions();
 }
 
+WTrackMenu::~WTrackMenu() {
+    // ~QPointer() needs the definition of the wrapped type
+    // upon deletion! Otherwise the behavior is undefined.
+    // The wrapped types of some QPointer members are only
+    // forward declared in the header file.
+}
+
 void WTrackMenu::popup(const QPoint& pos, QAction* at) {
     if (getTrackPointers().empty()) {
         return;
diff --git a/src/widget/wtrackmenu.h b/src/widget/wtrackmenu.h
index f4a25a4794..8d45d87087 100644
--- a/src/widget/wtrackmenu.h
+++ b/src/widget/wtrackmenu.h
@@ -50,8 +50,7 @@ class WTrackMenu : public QMenu {
             TrackCollectionManager* pTrackCollectionManager,
             Features flags = Feature::All,
             TrackModel* trackModel = nullptr);
-
-    ~WTrackMenu() override = default;
+    ~WTrackMenu() override;
 
     void loadTrack(TrackId trackId);
     void loadTrack(QModelIndex index);