diff options
| author | Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de> | 2020-11-17 20:02:14 +0100 |
|---|---|---|
| committer | Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de> | 2020-11-19 19:46:54 +0100 |
| commit | 4e1bebf0f5e06ecdd99c41771e7b4ee19c0cdcf3 (patch) | |
| tree | d0e98cee9eef416282049092ea93b0b2b6eb417d /src/widget/wdisplay.cpp | |
| parent | 133ea1e3d6547964f014144eee15590ea449c7af (diff) | |
Pass non-trivial/large function args by reference
Fixes a bunch of `-Wclazy-function-args-by-ref` warnings. See
https://github.com/KDE/clazy/blob/master/docs/checks/README-function-args-by-ref.md
for details.
Most of these changes are automated, using the clazy fixit by setting
the `CLAZY_EXPORT_FIXES` before compilation and then running:
$ mkdir /tmp/patch
$ find ../src -iname "*.yaml" -exec mv {} /tmp/patch \;
$ clang-apply-replacements /tmp/patch
Diffstat (limited to 'src/widget/wdisplay.cpp')
| -rw-r--r-- | src/widget/wdisplay.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/widget/wdisplay.cpp b/src/widget/wdisplay.cpp index 70d072709c..f2110bfcdd 100644 --- a/src/widget/wdisplay.cpp +++ b/src/widget/wdisplay.cpp @@ -98,9 +98,9 @@ void WDisplay::resetPositions() { m_disabledPixmaps.resize(0); } -void WDisplay::setPixmapBackground(PixmapSource source, - Paintable::DrawMode mode, - double scaleFactor) { +void WDisplay::setPixmapBackground(const PixmapSource& source, + Paintable::DrawMode mode, + double scaleFactor) { m_pPixmapBack = WPixmapStore::getPaintable(source, mode, scaleFactor); if (m_pPixmapBack.isNull() || m_pPixmapBack->isNull()) { qDebug() << metaObject()->className() |