summaryrefslogtreecommitdiffstats
path: root/src/sources
diff options
context:
space:
mode:
authorUwe Klotz <uklotz@mixxx.org>2021-06-18 00:24:24 +0200
committerUwe Klotz <uklotz@mixxx.org>2021-06-18 00:24:24 +0200
commitff2b9a066fe180539f2a1955b7ad1dcf4af829c0 (patch)
treef7db39ff692cd10f0459ba4a6b4c34597c4355de /src/sources
parent207043d250b8a2c10250c647100bf01d1e4d5007 (diff)
parentb49f33b6daa86c2a88b4e096eedd18815ef25245 (diff)
Merge branch '2.3' of git@github.com:mixxxdj/mixxx.git
# Conflicts: # .github/workflows/build.yml # .gitignore # CMakeLists.txt
Diffstat (limited to 'src/sources')
-rw-r--r--src/sources/metadatasourcetaglib.cpp8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/sources/metadatasourcetaglib.cpp b/src/sources/metadatasourcetaglib.cpp
index 9893623e29..4458417a20 100644
--- a/src/sources/metadatasourcetaglib.cpp
+++ b/src/sources/metadatasourcetaglib.cpp
@@ -639,6 +639,14 @@ class SafelyWritableFile final {
// See also: https://bugs.launchpad.net/mixxx/+bug/1815305
DEBUG_ASSERT(m_origFileName.isNull());
DEBUG_ASSERT(m_tempFileName.isNull());
+ if (!QFileInfo(origFileName).isWritable()) {
+ kLogger.warning()
+ << "Failed to prepare file for writing:"
+ << origFileName
+ << "is not writable.";
+ // Abort constructor
+ return;
+ }
if (useTemporaryFile) {
QString tempFileName = origFileName + kSafelyWritableTempFileSuffix;
QFile origFile(origFileName);