summaryrefslogtreecommitdiffstats
path: root/src/sources/soundsourcecoreaudio.cpp
diff options
context:
space:
mode:
authorUwe Klotz <uklotz@mixxx.org>2019-09-24 09:18:42 +0200
committerUwe Klotz <uklotz@mixxx.org>2019-10-20 22:36:34 +0200
commitf17c9bedcc6f10727374a19bd20f1c263930fdc2 (patch)
treec86b3be5ce4f9a59a9970d066652a8cf3e8a3674 /src/sources/soundsourcecoreaudio.cpp
parentf20edc50e69c72f0467185e746e43be651eab403 (diff)
Adjust priority of SoundSourceProviderCoreAudio
Diffstat (limited to 'src/sources/soundsourcecoreaudio.cpp')
-rw-r--r--src/sources/soundsourcecoreaudio.cpp16
1 files changed, 11 insertions, 5 deletions
diff --git a/src/sources/soundsourcecoreaudio.cpp b/src/sources/soundsourcecoreaudio.cpp
index 3cf0d3a360..b3f39d9f05 100644
--- a/src/sources/soundsourcecoreaudio.cpp
+++ b/src/sources/soundsourcecoreaudio.cpp
@@ -272,12 +272,18 @@ QStringList SoundSourceProviderCoreAudio::getSupportedFileExtensions() const {
supportedFileExtensions.append("m4a");
supportedFileExtensions.append("mp3");
supportedFileExtensions.append("mp2");
- //Can add mp3, mp2, ac3, and others here if you want.
- //See:
- // http://developer.apple.com/library/mac/documentation/MusicAudio/Reference/AudioFileConvertRef/Reference/reference.html#//apple_ref/doc/c_ref/AudioFileTypeID
-
- //XXX: ... but make sure you implement handling for any new format in ParseHeader!!!!!! -- asantoni
+ // Can add mp3, mp2, ac3, and others here if you want:
+ // http://developer.apple.com/library/mac/documentation/MusicAudio/Reference/AudioFileConvertRef/Reference/reference.html#//apple_ref/doc/c_ref/AudioFileTypeID
return supportedFileExtensions;
}
+SoundSourceProviderPriority SoundSourceProviderCoreAudio::getPriorityHint(
+ const QString& /*supportedFileExtension*/) const {
+ // On macOS CoreAudio is used both for decoding MP3 and M4A files. Neither
+ // FFmpeg nor libMAD are enabled in the release builds. In order to avoid
+ // priority conflicts with libMAD when enabled in the future the priority
+ // of this SoundSource is set to HIGHER.
+ return SoundSourceProviderPriority::HIGHER;
+}
+
} // namespace mixxx