Merge remote-tracking branch 'upstream/2.3' into main

2 files changed, 3 insertions, 3 deletions

diff --git a/src/recording/recordingmanager.cpp b/src/recording/recordingmanager.cpp
index 5988262e77..027d8a15de 100644
--- a/src/recording/recordingmanager.cpp
+++ b/src/recording/recordingmanager.cpp
@@ -68,7 +68,7 @@ RecordingManager::~RecordingManager() {
     delete m_pToggleRecording;
 }
 
-QString RecordingManager::formatDateTimeForFilename(QDateTime dateTime) const {
+QString RecordingManager::formatDateTimeForFilename(const QDateTime& dateTime) const {
     // Use a format based on ISO 8601. Windows does not support colons in
     // filenames so we can't use them anywhere.
     QString formatted = dateTime.toString("yyyy-MM-dd_hh'h'mm'm'ss's'");
diff --git a/src/recording/recordingmanager.h b/src/recording/recordingmanager.h
index f33f068d0e..aefe06b37d 100644
--- a/src/recording/recordingmanager.h
+++ b/src/recording/recordingmanager.h
@@ -44,7 +44,7 @@ class RecordingManager : public QObject {
     // Emits the cumulative number of bytes currently recorded.
     void bytesRecorded(int);
     void isRecording(bool);
-    void durationRecorded(QString);
+    void durationRecorded(const QString&);
 
   public slots:
     void slotIsRecording(bool recording, bool error);
@@ -54,7 +54,7 @@ class RecordingManager : public QObject {
     void slotToggleRecording(double value);
 
   private:
-    QString formatDateTimeForFilename(QDateTime dateTime) const;
+    QString formatDateTimeForFilename(const QDateTime& dateTime) const;
     // slotBytesRecorded just noticed that recording must be interrupted
     // to split the file. The nth filename will follow the date/time
     // name of the first split but with a suffix.