summaryrefslogtreecommitdiffstats
path: root/src/network
diff options
context:
space:
mode:
authorUwe Klotz <uklotz@mixxx.org>2020-12-31 14:08:52 +0100
committerUwe Klotz <uklotz@mixxx.org>2020-12-31 14:11:06 +0100
commit432b098d286505be28980276b34fc0e5d2cf5812 (patch)
treefac599bdf3ac3ded52830a7e873b2d3b3950fab8 /src/network
parentd655946faa44d84536f12718e1947c5f9737211a (diff)
Delete local variable to resolve auto-nitpicking
Diffstat (limited to 'src/network')
-rw-r--r--src/network/webtask.cpp8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/network/webtask.cpp b/src/network/webtask.cpp
index 72f3b06c87..02d2f037b6 100644
--- a/src/network/webtask.cpp
+++ b/src/network/webtask.cpp
@@ -179,14 +179,14 @@ void WebTask::slotStart(int timeoutMillis) {
<< this
<< "Starting...";
- auto* const pPendingNetworkReply = doStartNetworkRequest(
+ m_pendingNetworkReplyWeakPtr = doStartNetworkRequest(
pNetworkAccessManager,
timeoutMillis);
// Still idle, because we are in the same thread.
// The callee is not supposed to abort a request
// before it has beeen started successfully.
DEBUG_ASSERT(m_state == State::Idle);
- if (!pPendingNetworkReply) {
+ if (!m_pendingNetworkReplyWeakPtr) {
kLogger.debug()
<< "Network task has not been started";
return;
@@ -201,13 +201,11 @@ void WebTask::slotStart(int timeoutMillis) {
// It is not necessary to connect the QNetworkReply::errorOccurred signal.
// Network errors are also received through the QNetworkReply::finished signal.
- connect(pPendingNetworkReply,
+ connect(m_pendingNetworkReplyWeakPtr.data(),
&QNetworkReply::finished,
this,
&WebTask::slotNetworkReplyFinished,
Qt::UniqueConnection);
-
- m_pendingNetworkReplyWeakPtr = pPendingNetworkReply;
}
void WebTask::abort() {