diff options
| author | Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de> | 2020-01-15 15:57:53 +0100 |
|---|---|---|
| committer | Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de> | 2020-01-15 16:43:05 +0100 |
| commit | 533ab6d1fc0b1eab0506929c03c5a18082e3a43a (patch) | |
| tree | 4b60427cef5a2eeac25dfc5f8136c9c0f71db016 /src/library/recording | |
| parent | 33be6cd0407060cee76c7164e5de12874ffd053e (diff) | |
Fix inconsistent missing overrides in Mixxx codebase
This fixes 83 instances of [-Winconstent-missing-override]:
$ grep missing-override clazy-master.log | sort | uniq
src/library/baseexternallibraryfeature.h:23:18: warning: 'bindSidebarWidget' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/baseexternallibraryfeature.h:24:18: warning: 'onRightClick' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/baseexternallibraryfeature.h:25:18: warning: 'onRightClickChild' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/baseplaylistfeature.h:32:20: warning: 'getChildModel' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/baseplaylistfeature.h:34:10: warning: 'bindLibraryWidget' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/baseplaylistfeature.h:42:18: warning: 'activate' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/baseplaylistfeature.h:43:18: warning: 'activateChild' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/recording/recordingfeature.h:29:10: warning: 'bindLibraryWidget' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/recording/recordingfeature.h:32:20: warning: 'getChildModel' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/recording/recordingfeature.h:35:10: warning: 'activate' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/rekordbox/rekordboxfeature.h:55:18: warning: 'initSortColumnMapping' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/rekordbox/rekordboxfeature.h:70:20: warning: 'getChildModel' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/rekordbox/rekordboxfeature.h:73:10: warning: 'activate' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/rekordbox/rekordboxfeature.h:74:10: warning: 'activateChild' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/traktor/traktorfeature.h:45:20: warning: 'getChildModel' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/traktor/traktorfeature.h:48:10: warning: 'activate' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/traktor/traktorfeature.h:49:10: warning: 'activateChild' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/library/traktor/traktorfeature.h:54:32: warning: 'getPlaylistModelForPlaylist' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/test/autodjprocessor_test.cpp:77:18: warning: 'getLoadedTrack' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/test/mockedenginebackendtest.h:40:10: warning: 'clear' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
src/test/portmidicontroller_test.cpp:28:10: warning: 'sendShortMsg' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
Diffstat (limited to 'src/library/recording')
| -rw-r--r-- | src/library/recording/recordingfeature.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/library/recording/recordingfeature.h b/src/library/recording/recordingfeature.h index 732f0664c5..2fb8234f73 100644 --- a/src/library/recording/recordingfeature.h +++ b/src/library/recording/recordingfeature.h @@ -27,12 +27,12 @@ class RecordingFeature final : public LibraryFeature { QIcon getIcon() override; void bindLibraryWidget(WLibrary* libraryWidget, - KeyboardEventFilter* keyboard); + KeyboardEventFilter* keyboard) override; - TreeItemModel* getChildModel(); + TreeItemModel* getChildModel() override; public slots: - void activate(); + void activate() override; signals: void setRootIndex(const QModelIndex&); |