Merge remote-tracking branch 'upstream/2.3' into main

2 files changed, 6 insertions, 6 deletions

diff --git a/src/library/recording/dlgrecording.cpp b/src/library/recording/dlgrecording.cpp
index c2a1c892f7..292a7a1491 100644
--- a/src/library/recording/dlgrecording.cpp
+++ b/src/library/recording/dlgrecording.cpp
@@ -139,7 +139,7 @@ void DlgRecording::slotAddToAutoDJReplace() {
     m_pTrackTableView->slotAddToAutoDJReplace();
 }
 
-void DlgRecording::loadSelectedTrackToGroup(QString group, bool play) {
+void DlgRecording::loadSelectedTrackToGroup(const QString& group, bool play) {
     m_pTrackTableView->loadSelectedTrackToGroup(group, play);
 }
 
@@ -178,7 +178,7 @@ void DlgRecording::slotBytesRecorded(int bytes) {
 }
 
 // gets recorded duration and update label
-void DlgRecording::slotDurationRecorded(QString durationRecorded) {
+void DlgRecording::slotDurationRecorded(const QString& durationRecorded) {
     m_durationRecordedStr = durationRecorded;
     refreshLabels();
 }
diff --git a/src/library/recording/dlgrecording.h b/src/library/recording/dlgrecording.h
index d6b3818771..226d977c23 100644
--- a/src/library/recording/dlgrecording.h
+++ b/src/library/recording/dlgrecording.h
@@ -30,7 +30,7 @@ class DlgRecording : public QWidget, public Ui::DlgRecording, public virtual Lib
     void slotAddToAutoDJBottom() override;
     void slotAddToAutoDJTop() override;
     void slotAddToAutoDJReplace() override;
-    void loadSelectedTrackToGroup(QString group, bool play) override;
+    void loadSelectedTrackToGroup(const QString& group, bool play) override;
     void moveSelection(int delta) override;
     inline const QString currentSearch() { return m_proxyModel.currentSearch(); }
 
@@ -39,12 +39,12 @@ class DlgRecording : public QWidget, public Ui::DlgRecording, public virtual Lib
     void slotBytesRecorded(int);
     void refreshBrowseModel();
     void slotRestoreSearch();
-    void slotDurationRecorded(QString durationRecorded);
+    void slotDurationRecorded(const QString& durationRecorded);
 
   signals:
     void loadTrack(TrackPointer tio);
-    void loadTrackToPlayer(TrackPointer tio, QString group, bool play);
-    void restoreSearch(QString search);
+    void loadTrackToPlayer(TrackPointer tio, const QString& group, bool play);
+    void restoreSearch(const QString& search);
 
   private:
     UserSettingsPointer m_pConfig;