summaryrefslogtreecommitdiffstats
path: root/src/library/browse
diff options
context:
space:
mode:
authorJan Holthuis <jan.holthuis@ruhr-uni-bochum.de>2020-11-19 22:58:41 +0100
committerJan Holthuis <jan.holthuis@ruhr-uni-bochum.de>2020-11-19 23:09:17 +0100
commit6841b6d9bb78af28c4d89c936c5663b31aa4fd5a (patch)
tree4e1106c00da7192c5617681b6dce0493eac335a3 /src/library/browse
parent2d45cd84e262d7a4c6b977e7c6c26ce8d92c2615 (diff)
Do not return void expressions
Fixes a bunch of `-Wclazy-returning-void-expression` warnings, since returning void expressions is confusing and may hide subtle bugs. See https://github.com/KDE/clazy/blob/master/docs/checks/README-returning-void-expression.md for details.
Diffstat (limited to 'src/library/browse')
-rw-r--r--src/library/browse/browsethread.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/library/browse/browsethread.cpp b/src/library/browse/browsethread.cpp
index e3badf5d3d..774e56f9fc 100644
--- a/src/library/browse/browsethread.cpp
+++ b/src/library/browse/browsethread.cpp
@@ -142,7 +142,8 @@ void BrowseThread::populateModel() {
if (thisPath.dir() != newPath.dir()) {
qDebug() << "Abort populateModel()";
- return populateModel();
+ populateModel();
+ return;
}
QList<QStandardItem*> row_data;