diff options
author | Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de> | 2020-12-02 21:11:43 +0100 |
---|---|---|
committer | Jan Holthuis <jan.holthuis@ruhr-uni-bochum.de> | 2020-12-02 21:11:43 +0100 |
commit | b207bd38e1574cb75315a2c66e7a598c22fc55ca (patch) | |
tree | 05b3a58ac8261e1f43a944018e48c15171032052 /src/library/basetrackcache.cpp | |
parent | 8e18359de7cfc2521045671007ec6115c150dd55 (diff) | |
parent | 532b713e0e570083c8ecd5708942cacb66835838 (diff) |
Merge branch '2.3' of github.com:mixxxdj/mixxx into cleanup-headers
Diffstat (limited to 'src/library/basetrackcache.cpp')
-rw-r--r-- | src/library/basetrackcache.cpp | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/src/library/basetrackcache.cpp b/src/library/basetrackcache.cpp index 8f5eb38993..93f3e1931a 100644 --- a/src/library/basetrackcache.cpp +++ b/src/library/basetrackcache.cpp @@ -72,7 +72,7 @@ QString BaseTrackCache::columnSortForFieldIndex(int index) const { return m_columnCache.columnSortForFieldIndex(index); } -void BaseTrackCache::slotTracksAddedOrChanged(QSet<TrackId> trackIds) { +void BaseTrackCache::slotTracksAddedOrChanged(const QSet<TrackId>& trackIds) { if (sDebug) { qDebug() << this << "slotTracksAddedOrChanged" << trackIds.size(); } @@ -86,7 +86,7 @@ void BaseTrackCache::slotScanTrackAdded(TrackPointer pTrack) { updateTrackInIndex(pTrack); } -void BaseTrackCache::slotTracksRemoved(QSet<TrackId> trackIds) { +void BaseTrackCache::slotTracksRemoved(const QSet<TrackId>& trackIds) { if (sDebug) { qDebug() << this << "slotTracksRemoved" << trackIds.size(); } @@ -120,7 +120,7 @@ void BaseTrackCache::ensureCached(TrackId trackId) { updateTrackInIndex(trackId); } -void BaseTrackCache::ensureCached(QSet<TrackId> trackIds) { +void BaseTrackCache::ensureCached(const QSet<TrackId>& trackIds) { updateTracksInIndex(trackIds); } @@ -673,8 +673,10 @@ int BaseTrackCache::findSortInsertionPoint(TrackPointer pTrack, return min; } -int BaseTrackCache::compareColumnValues(int sortColumn, Qt::SortOrder sortOrder, - QVariant val1, QVariant val2) const { +int BaseTrackCache::compareColumnValues(int sortColumn, + Qt::SortOrder sortOrder, + const QVariant& val1, + const QVariant& val2) const { int result = 0; if (sortColumn == fieldIndex(ColumnCache::COLUMN_LIBRARYTABLE_YEAR) || |