diff options
author | RJ Ryan <rryan@mixxx.org> | 2013-11-30 19:19:10 -0500 |
---|---|---|
committer | RJ Ryan <rryan@mixxx.org> | 2013-11-30 19:19:10 -0500 |
commit | 4845e95acb542120191f309e050d785699730048 (patch) | |
tree | 34796d4c030011d77ee083713b4a302875b94bf3 /src/library/banshee | |
parent | 64e7966c2a2b83b136b56086b6c8de2bb3dcdcd0 (diff) |
Header/include cleanups across the codebase.
* Eliminate all instances of including QtCore, QtGui, or QtXml.
* Replace all old-style Qt header inclusions with new-style (e.g. #include <application.h>).
* Include QtDebug instead of QDebug.
* Update many classes to include the Qt classes they use in their header and implementation file.
This speeds up compile and link performance and reduces the size of the compiled object files. My build directory dropped by 50MB.
Diffstat (limited to 'src/library/banshee')
-rw-r--r-- | src/library/banshee/bansheedbconnection.cpp | 2 | ||||
-rw-r--r-- | src/library/banshee/bansheefeature.cpp | 8 | ||||
-rw-r--r-- | src/library/banshee/bansheeplaylistmodel.h | 2 |
3 files changed, 1 insertions, 11 deletions
diff --git a/src/library/banshee/bansheedbconnection.cpp b/src/library/banshee/bansheedbconnection.cpp index 95f68a7121..d81ecff403 100644 --- a/src/library/banshee/bansheedbconnection.cpp +++ b/src/library/banshee/bansheedbconnection.cpp @@ -4,6 +4,7 @@ #include <QFile> #include <QFileInfo> #include <QSqlError> + #include "library/queryutil.h" #include "bansheedbconnection.h" @@ -228,4 +229,3 @@ QString BansheeDbConnection::getDatabaseFile() { return QString(); } - diff --git a/src/library/banshee/bansheefeature.cpp b/src/library/banshee/bansheefeature.cpp index 6cf591a0d7..66d9dca74b 100644 --- a/src/library/banshee/bansheefeature.cpp +++ b/src/library/banshee/bansheefeature.cpp @@ -1,10 +1,5 @@ #include <QMessageBox> #include <QtDebug> -#include <QXmlStreamReader> -#include <QDesktopServices> -#include <QFileDialog> -#include <QMenu> -#include <QAction> #include <QList> #include "library/banshee/bansheefeature.h" @@ -166,6 +161,3 @@ void BansheeFeature::appendTrackIdsFromRightClickIndex(QList<int>* trackIds, QSt } } } - - - diff --git a/src/library/banshee/bansheeplaylistmodel.h b/src/library/banshee/bansheeplaylistmodel.h index d717b7f183..f7aeccd859 100644 --- a/src/library/banshee/bansheeplaylistmodel.h +++ b/src/library/banshee/bansheeplaylistmodel.h @@ -1,9 +1,7 @@ #ifndef BANSHEEPLAYLISTMODEL_H #define BANSHEEPLAYLISTMODEL_H -#include <QtCore> #include <QHash> -#include <QtGui> #include <QtSql> #include "library/trackmodel.h" |