Use const QString& in some places

1 files changed, 6 insertions, 6 deletions

diff --git a/src/errordialoghandler.h b/src/errordialoghandler.h
index 1dcd2706e7..77762dece7 100644
--- a/src/errordialoghandler.h
+++ b/src/errordialoghandler.h
@@ -46,10 +46,10 @@ typedef enum {
 class ErrorDialogProperties {
   public:
     /** Set the window title. ("Mixxx" is always prepended.) */
-    void setTitle(QString title);
+    void setTitle(const QString& title);
 
     /** Set a key to prevent multiple dialogs until the first is closed */
-    inline void setKey(QString key) {
+    inline void setKey(const QString& key) {
         m_key = key;
     }
 
@@ -58,18 +58,18 @@ class ErrorDialogProperties {
     }
 
     /** Set the primary window text */
-    void setText(QString text);
+    void setText(const QString& text);
     QString getText() const {
         return m_text;
     }
 
     /** Set additional window text */
-    inline void setInfoText(QString text) {
+    inline void setInfoText(const QString& text) {
         m_infoText = text;
     }
 
     /** Set detailed text (causes "Show Details" button to appear.) */
-    inline void setDetails(QString text) {
+    inline void setDetails(const QString& text) {
         m_details = text;
     }
 
@@ -152,7 +152,7 @@ class ErrorDialogHandler : public QObject {
     // (or title if no key) is already displayed. If shouldQuit is true, Mixxx
     // will shut down.
     bool requestErrorDialog(DialogType type, QString message,
-                            bool shouldQuit=false);
+                            bool shouldQuit = false);
     bool requestErrorDialog(ErrorDialogProperties* props);
 
     // Allows a means for main() to skip exec() if there was a critical or fatal