diff options
author | Daniel Schürmann <daschuer@mixxx.org> | 2015-05-30 20:23:51 +0200 |
---|---|---|
committer | Daniel Schürmann <daschuer@mixxx.org> | 2019-11-16 11:58:18 +0100 |
commit | 0c83981e12c6f49383f88b3708ed4d3e1a0d6556 (patch) | |
tree | 427c4e13f08580abd4ed6a201ac8406317ba426f /src/engine/sidechain | |
parent | ba9970a275041e7108c6598acfe0885e6b7eb24d (diff) |
Use static const QStrings instead of string literals
this avoids allocating memory and unicode conversion over and over again
Diffstat (limited to 'src/engine/sidechain')
-rw-r--r-- | src/engine/sidechain/enginerecord.cpp | 7 | ||||
-rw-r--r-- | src/engine/sidechain/enginesidechain.cpp | 8 |
2 files changed, 8 insertions, 7 deletions
diff --git a/src/engine/sidechain/enginerecord.cpp b/src/engine/sidechain/enginerecord.cpp index d63e074bd4..af000ff421 100644 --- a/src/engine/sidechain/enginerecord.cpp +++ b/src/engine/sidechain/enginerecord.cpp @@ -109,11 +109,12 @@ bool EngineRecord::metaDataHasChanged() void EngineRecord::process(const CSAMPLE* pBuffer, const int iBufferSize) { float recordingStatus = m_pRecReady->get(); + static const QString tag("EngineRecord recording"); if (recordingStatus == RECORD_OFF) { //qDebug("Setting record flag to: OFF"); if (fileOpen()) { - Event::end("EngineRecord recording"); + Event::end(tag); closeFile(); // Close file and free encoder. if (m_bCueIsEnabled) { closeCueFile(); @@ -125,7 +126,7 @@ void EngineRecord::process(const CSAMPLE* pBuffer, const int iBufferSize) { // open a new file. updateFromPreferences(); // Update file location from preferences. if (openFile()) { - Event::start("EngineRecord recording"); + Event::start(tag); qDebug("Setting record flag to: ON"); m_pRecReady->set(RECORD_ON); emit(isRecording(true, false)); // will notify the RecordingManager @@ -177,7 +178,7 @@ void EngineRecord::process(const CSAMPLE* pBuffer, const int iBufferSize) { } } else { // Maybe the encoder could not be initialized qDebug() << "Could not open" << m_fileName << "for writing."; - Event::end("EngineRecord recording"); + Event::end(tag); qDebug("Setting record flag to: OFF"); m_pRecReady->slotSet(RECORD_OFF); // An error occurred. diff --git a/src/engine/sidechain/enginesidechain.cpp b/src/engine/sidechain/enginesidechain.cpp index 6a88b08e77..eab8c42b1e 100644 --- a/src/engine/sidechain/enginesidechain.cpp +++ b/src/engine/sidechain/enginesidechain.cpp @@ -106,16 +106,16 @@ void EngineSideChain::run() { // factor this out somehow), -kousu 2/2009 unsigned static id = 0; QThread::currentThread()->setObjectName(QString("EngineSideChain %1").arg(++id)); - - Event::start("EngineSideChain"); + static const QString tag("EngineSideChain"); + Event::start(tag); while (!m_bStopThread) { // Sleep until samples are available. m_waitLock.lock(); - Event::end("EngineSideChain"); + Event::end(tag); m_waitForSamples.wait(&m_waitLock); m_waitLock.unlock(); - Event::start("EngineSideChain"); + Event::start(tag); int samples_read; while ((samples_read = m_sampleFifo.read(m_pWorkBuffer, |