summaryrefslogtreecommitdiffstats
path: root/src/engine/enginebuffer.cpp
diff options
context:
space:
mode:
authorJoergAtGithub <JoergAtGithub@worldwartweb.com>2021-03-02 20:10:22 +0100
committerJoergAtGithub <JoergAtGithub@worldwartweb.com>2021-03-02 20:10:22 +0100
commitfd644116d3cb2151e4b5e5a391c0c84344f00e2e (patch)
tree20533be754c9dbce763b21530ab502a37350dea7 /src/engine/enginebuffer.cpp
parent93feabe67c2e3452941446ae17edb345bbcc78b4 (diff)
Added ToDo comment about moving the updateIndicators to waveform update loop.
Diffstat (limited to 'src/engine/enginebuffer.cpp')
-rw-r--r--src/engine/enginebuffer.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/engine/enginebuffer.cpp b/src/engine/enginebuffer.cpp
index cae33bd1b3..9593905856 100644
--- a/src/engine/enginebuffer.cpp
+++ b/src/engine/enginebuffer.cpp
@@ -1351,6 +1351,10 @@ void EngineBuffer::updateIndicators(double speed, int iBufferSize) {
fractionalPlayposFromAbsolute(m_dSlipPosition),
tempoTrackSeconds);
+ // TODO: Especially with long audio buffers, jitter is visible. This can be fixed by moving the
+ // ClockControl::updateIndicators into the waveform update loop which is synced with the display refresh rate.
+ // Via the visual play position it's possible to access to the sample that is currently played,
+ // and not the one that have been processed as in the current solution.
m_pClockControl->updateIndicators(speed * m_baserate_old, m_filepos_play, m_pSampleRate->get());
}