guard qDebug output in engine thread with kEffectDebugOutput bool

emitting debugging output from the engine output can cause audio
dropouts

2 files changed, 11 insertions, 7 deletions

diff --git a/src/engine/effects/engineeffect.cpp b/src/engine/effects/engineeffect.cpp
index 36cc6f0f1b..063d12884b 100644
--- a/src/engine/effects/engineeffect.cpp
+++ b/src/engine/effects/engineeffect.cpp
@@ -62,7 +62,10 @@ EffectState* EngineEffect::createState(const mixxx::EngineParameters& bufferPara
 
 void EngineEffect::loadStatesForInputChannel(const ChannelHandle& inputChannel,
     const EffectStatesPointer states) {
-    qDebug() << "EngineEffect::loadStatesForInputChannel" << this << "loading states for input" << inputChannel;
+    if (kEffectDebugOutput) {
+        qDebug() << "EngineEffect::loadStatesForInputChannel" << this
+                 << "loading states for input" << inputChannel;
+    }
     m_pProcessor->loadStatesForInputChannel(inputChannel, states);
 }
 
diff --git a/src/engine/effects/engineeffectchain.cpp b/src/engine/effects/engineeffectchain.cpp
index c890a02abe..a0ecba3d96 100644
--- a/src/engine/effects/engineeffectchain.cpp
+++ b/src/engine/effects/engineeffectchain.cpp
@@ -143,20 +143,21 @@ bool EngineEffectChain::processEffectsRequest(const EffectsRequest& message,
 
 bool EngineEffectChain::enableForInputChannel(const ChannelHandle& inputHandle,
         const QList<EffectStatesPointer>* statesForEffectsInChain) {
-    qDebug() << "EngineEffectChain::enableForInputChannel" << this << inputHandle;
+    if (kEffectDebugOutput) {
+        qDebug() << "EngineEffectChain::enableForInputChannel" << this << inputHandle;
+    }
     auto& outputMap = m_chainStatusForChannelMatrix[inputHandle];
     for (auto&& outputChannelStatus : outputMap) {
         if (outputChannelStatus.enable_state != EffectEnableState::Enabled) {
             outputChannelStatus.enable_state = EffectEnableState::Enabling;
         }
     }
-//     VERIFY_OR_DEBUG_ASSERT(m_effects.size() > 0) {
-//         return false;
-//     }
     for (int i = 0; i < m_effects.size(); ++i) {
         if (m_effects[i] != nullptr) {
-            qDebug() << "EngineEffectChain::enableForInputChannel" << this
-                     << "loading states for effect" << i;
+            if (kEffectDebugOutput) {
+                qDebug() << "EngineEffectChain::enableForInputChannel" << this
+                        << "loading states for effect" << i;
+            }
             EffectStatesPointer pStates = statesForEffectsInChain->at(i);
             VERIFY_OR_DEBUG_ASSERT(pStates != nullptr) {
                 return false;