summaryrefslogtreecommitdiffstats
path: root/src/dialog
diff options
context:
space:
mode:
authorDaniel Poelzleithner <git@poelzi.org>2021-01-24 17:39:54 +0100
committerDaniel Poelzleithner <git@poelzi.org>2021-01-24 18:13:56 +0100
commited533bb8889ced48ca031a2a79273e411e1d90f3 (patch)
tree6c92e6b54ab5f3103cd021f4c337505cdc3a870c /src/dialog
parentcfa96034f2cd8e72e39b7930db3b53c0547a220e (diff)
Cleanup keywheel code
Diffstat (limited to 'src/dialog')
-rw-r--r--src/dialog/dlgkeywheel.cpp8
-rw-r--r--src/dialog/dlgkeywheel.h4
2 files changed, 6 insertions, 6 deletions
diff --git a/src/dialog/dlgkeywheel.cpp b/src/dialog/dlgkeywheel.cpp
index 61d8a5a7ae..f3269019e9 100644
--- a/src/dialog/dlgkeywheel.cpp
+++ b/src/dialog/dlgkeywheel.cpp
@@ -9,20 +9,20 @@
using namespace mixxx::track::io::key;
namespace {
-auto kKeywheelSVG = QStringLiteral("images/keywheel/keywheel.svg");
+const auto kKeywheelSVG = QStringLiteral("images/keywheel/keywheel.svg");
const KeyUtils::KeyNotation kNotationHidden[]{
KeyUtils::KeyNotation::OpenKeyAndTraditional,
KeyUtils::KeyNotation::LancelotAndTraditional};
} // namespace
-DlgKeywheel::DlgKeywheel(QWidget* parent, UserSettingsPointer pConfig)
+DlgKeywheel::DlgKeywheel(QWidget* parent, const UserSettingsPointer& pConfig)
: QDialog(parent),
ui(new Ui::DlgKeywheel),
m_pConfig(pConfig) {
ui->setupUi(this);
QDir resourceDir(m_pConfig->getResourcePath());
auto svgPath = resourceDir.filePath(kKeywheelSVG);
- qDebug() << svgPath;
+
QFile xmlFile(svgPath);
if (!xmlFile.exists() || !xmlFile.open(QFile::ReadOnly | QFile::Text)) {
qDebug() << "Could not load template: " << svgPath;
@@ -63,7 +63,7 @@ bool DlgKeywheel::eventFilter(QObject* obj, QEvent* event) {
return true;
}
// standard event processing
- return QObject::eventFilter(obj, event);
+ return QDialog::eventFilter(obj, event);
}
void DlgKeywheel::resizeEvent(QResizeEvent* ev) {
diff --git a/src/dialog/dlgkeywheel.h b/src/dialog/dlgkeywheel.h
index 7d689c9155..a249020c18 100644
--- a/src/dialog/dlgkeywheel.h
+++ b/src/dialog/dlgkeywheel.h
@@ -17,7 +17,7 @@ class DlgKeywheel : public QDialog {
Q_OBJECT
public:
- explicit DlgKeywheel(QWidget* parent, UserSettingsPointer pConfig);
+ explicit DlgKeywheel(QWidget* parent, const UserSettingsPointer& pConfig);
void switchDisplay(int dir = 1);
void updateSvg();
~DlgKeywheel();
@@ -32,7 +32,7 @@ class DlgKeywheel : public QDialog {
QDomDocument m_domDocument;
Ui::DlgKeywheel* ui;
QSvgWidget* m_wheel;
- UserSettingsPointer m_pConfig;
+ const UserSettingsPointer m_pConfig;
};
#endif // DLGKEYWHEEL_H