controlobjectscript: Use QVector instead of QList

QVector should be used if the contained type is larger than the current
platform's pointer type. Fixes -Wclazy-inefficient-qlist-soft warning.
See https://github.com/KDE/clazy/blob/master/docs/checks/README-inefficient-qlist-soft.md
for details.

2 files changed, 3 insertions, 3 deletions

diff --git a/src/control/controlobjectscript.cpp b/src/control/controlobjectscript.cpp
index 429a4d0230..ae6438e87e 100644
--- a/src/control/controlobjectscript.cpp
+++ b/src/control/controlobjectscript.cpp
@@ -66,7 +66,7 @@ bool ControlObjectScript::removeScriptConnection(const ScriptConnection& conn) {
 
 void ControlObjectScript::disconnectAllConnectionsToFunction(const QScriptValue& function) {
     // Make a local copy of m_scriptConnections because items are removed within the loop.
-    const QList<ScriptConnection> connections = m_scriptConnections;
+    const QVector<ScriptConnection> connections = m_scriptConnections;
     for (const auto& conn: connections) {
         if (conn.callback.strictlyEquals(function)) {
             removeScriptConnection(conn);
@@ -79,7 +79,7 @@ void ControlObjectScript::slotValueChanged(double value, QObject*) {
     // This allows a script to disconnect a callback from inside the
     // the callback. Otherwise the this may crash since the disconnect call
     // happens during conn.function.call() in the middle of the loop below.
-    const QList<ScriptConnection> connections = m_scriptConnections;
+    const QVector<ScriptConnection> connections = m_scriptConnections;
     for (auto&& conn: connections) {
         conn.executeCallback(value);
     }
diff --git a/src/control/controlobjectscript.h b/src/control/controlobjectscript.h
index 853c1435cf..87bf2171fa 100644
--- a/src/control/controlobjectscript.h
+++ b/src/control/controlobjectscript.h
@@ -38,7 +38,7 @@ class ControlObjectScript : public ControlProxy {
     void slotValueChanged(double v, QObject*);
 
   private:
-    QList<ScriptConnection> m_scriptConnections;
+    QVector<ScriptConnection> m_scriptConnections;
 };
 
 #endif // CONTROLOBJECTSCRIPT_H