summaryrefslogtreecommitdiffstats
path: root/build/mixxx.py
diff options
context:
space:
mode:
authorJan Holthuis <jan.holthuis@ruhr-uni-bochum.de>2019-08-11 17:06:17 +0200
committerJan Holthuis <jan.holthuis@ruhr-uni-bochum.de>2019-08-11 17:06:17 +0200
commit2b956c0e482dfc1efa2ad5d4a0c7f600d9bdbd5e (patch)
tree9e6b9553a2cb02deddc6bb38e675c1dded956fc2 /build/mixxx.py
parentabb345aaa28c67bba96b4dbfc6b6c33df6bba1d2 (diff)
scons: Move stdlib imports to top of file
Imports that are not at the top of file are considered bad style in Python. See this for details: https://legacy.python.org/dev/peps/pep-0008/#imports
Diffstat (limited to 'build/mixxx.py')
-rw-r--r--build/mixxx.py9
1 files changed, 4 insertions, 5 deletions
diff --git a/build/mixxx.py b/build/mixxx.py
index 47bb226e99..d2b7379231 100644
--- a/build/mixxx.py
+++ b/build/mixxx.py
@@ -3,11 +3,13 @@
from __future__ import with_statement
import logging
-import platform
-import sys
import os
+import platform
import re
+import shlex
import shutil
+import subprocess
+import sys
import SCons
from SCons import Script
@@ -158,7 +160,6 @@ class MixxxBuild(object):
if not os.path.isdir(default_qtdir) and self.platform == 'linux':
if any(os.access(os.path.join(path, 'pkg-config'), os.X_OK) for path in os.environ["PATH"].split(os.pathsep)):
try:
- import subprocess
pkg_config_cmd = ['pkg-config', '--variable=includedir', 'Qt5Core']
default_qtdir = subprocess.check_output(pkg_config_cmd).decode()
finally:
@@ -216,8 +217,6 @@ class MixxxBuild(object):
self.compiler_is_gcc = False
self.compiler_is_clang = False
else:
- import shlex
- import subprocess
cc_version_cmd = shlex.split(self.env['CC']) + ['--version']
cc_version = subprocess.check_output(cc_version_cmd).decode()
self.compiler_is_gcc = 'gcc' in cc_version.lower()