diff options
author | JoergAtGithub <JoergAtGithub@worldwartweb.com> | 2020-10-24 12:24:10 +0200 |
---|---|---|
committer | JoergAtGithub <JoergAtGithub@worldwartweb.com> | 2020-10-24 12:57:18 +0200 |
commit | dfc9c25669b76f2463f2132c292895bf82cf3666 (patch) | |
tree | f8b672918eea0c138e42d173da3002c112dd0e91 | |
parent | f80ed7f0de94a346cb05e5e17e2da069ddf8d7e8 (diff) |
Replaced if condition by VERIFY_OR_DEBUG_ASSERT
Fixed the condition for the maximum allowed value
-rw-r--r-- | src/library/browse/browsetablemodel.cpp | 2 | ||||
-rw-r--r-- | src/widget/wtracktableview.cpp | 9 |
2 files changed, 8 insertions, 3 deletions
diff --git a/src/library/browse/browsetablemodel.cpp b/src/library/browse/browsetablemodel.cpp index 23ccd5ad0c..85d91a7754 100644 --- a/src/library/browse/browsetablemodel.cpp +++ b/src/library/browse/browsetablemodel.cpp @@ -136,7 +136,7 @@ BrowseTableModel::~BrowseTableModel() { int BrowseTableModel::columnIndexFromSortColumnId(TrackModel::SortColumnId column) { if (column < TrackModel::SortColumnId::SORTCOLUMN_ID_MIN || - column > TrackModel::SortColumnId::SORTCOLUMN_ID_MAX) { + column >= TrackModel::SortColumnId::SORTCOLUMN_ID_MAX) { return -1; } diff --git a/src/widget/wtracktableview.cpp b/src/widget/wtracktableview.cpp index 9794c7e300..a79dac7010 100644 --- a/src/widget/wtracktableview.cpp +++ b/src/widget/wtracktableview.cpp @@ -945,8 +945,13 @@ void WTrackTableView::applySortingIfVisible() { void WTrackTableView::applySorting() { TrackModel* trackModel = getTrackModel(); int sortColumnId = static_cast<int>(m_pSortColumn->get()); - if (sortColumnId < TrackModel::SortColumnId::SORTCOLUMN_ID_MIN || - sortColumnId > TrackModel::SortColumnId::SORTCOLUMN_ID_MAX) { + if (sortColumnId == TrackModel::SortColumnId::SORTCOLUMN_INVALID) { + // During startup phase of Mixxx, this method is called with SORTCOLUMN_INVALID + return; + } + VERIFY_OR_DEBUG_ASSERT( + sortColumnId >= TrackModel::SortColumnId::SORTCOLUMN_ID_MIN && + sortColumnId < TrackModel::SortColumnId::SORTCOLUMN_ID_MAX) { return; } |