summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Schürmann <daschuer@mixxx.org>2020-06-10 23:01:12 +0200
committerDaniel Schürmann <daschuer@mixxx.org>2020-06-11 00:16:34 +0200
commit8dec534d522488a7af3d229cf5c46fa5777b5646 (patch)
tree4a591d6b6e5fc2ebe810c01b0beb93178e9cb926
parent1fe5ba1af7aa5edb3d54fc807798d266f40d2ad7 (diff)
Make QString m_group const
-rw-r--r--src/effects/effectparameterslotbase.h2
-rw-r--r--src/engine/cachingreader/cachingreaderworker.h2
-rw-r--r--src/engine/controls/cuecontrol.h2
-rw-r--r--src/engine/controls/enginecontrol.h2
-rw-r--r--src/engine/enginebuffer.h2
-rw-r--r--src/engine/sync/internalclock.h2
-rw-r--r--src/library/librarycontrol.h2
-rw-r--r--src/vinylcontrol/vinylcontrol.h2
-rw-r--r--src/waveform/visualsmanager.h2
-rw-r--r--src/widget/wcoverart.h2
-rw-r--r--src/widget/wspinny.h2
-rw-r--r--src/widget/wtracktext.h2
-rw-r--r--src/widget/wwaveformviewer.h2
13 files changed, 13 insertions, 13 deletions
diff --git a/src/effects/effectparameterslotbase.h b/src/effects/effectparameterslotbase.h
index fcdf1c854f..e0ba8d9549 100644
--- a/src/effects/effectparameterslotbase.h
+++ b/src/effects/effectparameterslotbase.h
@@ -32,7 +32,7 @@ class EffectParameterSlotBase : public QObject {
protected:
const unsigned int m_iParameterSlotNumber;
- QString m_group;
+ const QString m_group;
EffectPointer m_pEffect;
EffectParameter* m_pEffectParameter;
diff --git a/src/engine/cachingreader/cachingreaderworker.h b/src/engine/cachingreader/cachingreaderworker.h
index 5d94dbd21f..8588f3cb31 100644
--- a/src/engine/cachingreader/cachingreaderworker.h
+++ b/src/engine/cachingreader/cachingreaderworker.h
@@ -119,7 +119,7 @@ class CachingReaderWorker : public EngineWorker {
void trackLoadFailed(TrackPointer pTrack, QString reason);
private:
- QString m_group;
+ const QString m_group;
QString m_tag;
// Thread-safe FIFOs for communication between the engine callback and
diff --git a/src/engine/controls/cuecontrol.h b/src/engine/controls/cuecontrol.h
index 25b9a37324..3d4ce541c1 100644
--- a/src/engine/controls/cuecontrol.h
+++ b/src/engine/controls/cuecontrol.h
@@ -95,7 +95,7 @@ class HotcueControl : public QObject {
private:
ConfigKey keyForControl(int hotcue, const char* name);
- QString m_group;
+ const QString m_group;
int m_iHotcueNumber;
CuePointer m_pCue;
diff --git a/src/engine/controls/enginecontrol.h b/src/engine/controls/enginecontrol.h
index 5c625520dc..1fe3371e5e 100644
--- a/src/engine/controls/enginecontrol.h
+++ b/src/engine/controls/enginecontrol.h
@@ -91,7 +91,7 @@ class EngineControl : public QObject {
EngineMaster* getEngineMaster();
EngineBuffer* getEngineBuffer();
- QString m_group;
+ const QString m_group;
UserSettingsPointer m_pConfig;
private:
diff --git a/src/engine/enginebuffer.h b/src/engine/enginebuffer.h
index f0a8fb9909..0e61fadc71 100644
--- a/src/engine/enginebuffer.h
+++ b/src/engine/enginebuffer.h
@@ -249,7 +249,7 @@ class EngineBuffer : public EngineObject {
void processTrackLocked(CSAMPLE* pOutput, const int iBufferSize, int sample_rate);
// Holds the name of the control group
- QString m_group;
+ const QString m_group;
UserSettingsPointer m_pConfig;
friend class CueControlTest;
diff --git a/src/engine/sync/internalclock.h b/src/engine/sync/internalclock.h
index 21d819e6f4..c5093e32c2 100644
--- a/src/engine/sync/internalclock.h
+++ b/src/engine/sync/internalclock.h
@@ -65,7 +65,7 @@ class InternalClock : public QObject, public Clock, public Syncable {
private:
void updateBeatLength(int sampleRate, double bpm);
- QString m_group;
+ const QString m_group;
SyncableListener* m_pEngineSync;
QScopedPointer<ControlLinPotmeter> m_pClockBpm;
QScopedPointer<ControlObject> m_pClockBeatDistance;
diff --git a/src/library/librarycontrol.h b/src/library/librarycontrol.h
index 95967fbb90..6c438942c5 100644
--- a/src/library/librarycontrol.h
+++ b/src/library/librarycontrol.h
@@ -30,7 +30,7 @@ class LoadToGroupController : public QObject {
void slotLoadToGroupAndPlay(double v);
private:
- QString m_group;
+ const QString m_group;
std::unique_ptr<ControlObject> m_pLoadControl;
std::unique_ptr<ControlObject> m_pLoadAndPlayControl;
};
diff --git a/src/vinylcontrol/vinylcontrol.h b/src/vinylcontrol/vinylcontrol.h
index 5cd1370c23..805cc8dbdf 100644
--- a/src/vinylcontrol/vinylcontrol.h
+++ b/src/vinylcontrol/vinylcontrol.h
@@ -23,7 +23,7 @@ class VinylControl : public QObject {
virtual float getAngle() = 0;
UserSettingsPointer m_pConfig;
- QString m_group;
+ const QString m_group;
// The VC input gain preference.
ControlProxy* m_pVinylControlInputGain;
diff --git a/src/waveform/visualsmanager.h b/src/waveform/visualsmanager.h
index 459c4103af..bcc28c0c96 100644
--- a/src/waveform/visualsmanager.h
+++ b/src/waveform/visualsmanager.h
@@ -26,7 +26,7 @@ class DeckVisuals {
void process(double remainingTimeTriggerSeconds);
private:
- QString m_group;
+ const QString m_group;
int m_SlowTickCnt;
bool m_trackLoaded;
diff --git a/src/widget/wcoverart.h b/src/widget/wcoverart.h
index 98b2ab32e9..bd295a6893 100644
--- a/src/widget/wcoverart.h
+++ b/src/widget/wcoverart.h
@@ -62,7 +62,7 @@ class WCoverArt : public QWidget, public WBaseWidget, public TrackDropTarget {
private:
QPixmap scaledCoverArt(const QPixmap& normal);
- QString m_group;
+ const QString m_group;
UserSettingsPointer m_pConfig;
bool m_bEnable;
WCoverArtMenu* m_pMenu;
diff --git a/src/widget/wspinny.h b/src/widget/wspinny.h
index 5ae7a28c89..31d4e69c4e 100644
--- a/src/widget/wspinny.h
+++ b/src/widget/wspinny.h
@@ -82,7 +82,7 @@ class WSpinny : public QGLWidget, public WBaseWidget, public VinylSignalQualityL
QPixmap scaledCoverArt(const QPixmap& normal);
private:
- QString m_group;
+ const QString m_group;
UserSettingsPointer m_pConfig;
std::shared_ptr<QImage> m_pBgImage;
std::shared_ptr<QImage> m_pMaskImage;
diff --git a/src/widget/wtracktext.h b/src/widget/wtracktext.h
index 4dbed5c550..04521bf3b1 100644
--- a/src/widget/wtracktext.h
+++ b/src/widget/wtracktext.h
@@ -42,7 +42,7 @@ class WTrackText : public WLabel, public TrackDropTarget {
void updateLabel();
- QString m_group;
+ const QString m_group;
UserSettingsPointer m_pConfig;
TrackPointer m_pCurrentTrack;
const parented_ptr<WTrackMenu> m_pTrackMenu;
diff --git a/src/widget/wwaveformviewer.h b/src/widget/wwaveformviewer.h
index 09fa046fc7..b8b8df61ec 100644
--- a/src/widget/wwaveformviewer.h
+++ b/src/widget/wwaveformviewer.h
@@ -71,7 +71,7 @@ class WWaveformViewer : public WWidget, public TrackDropTarget {
void setPlayMarkerPosition(double position);
private:
- QString m_group;
+ const QString m_group;
UserSettingsPointer m_pConfig;
int m_zoomZoneWidth;
ControlProxy* m_pZoom;