summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTom Milligan <tommilligan@users.noreply.github.com>2023-04-16 12:46:38 +0100
committerGitHub <noreply@github.com>2023-04-16 12:46:38 +0100
commit90484a44ea54752d4068c0746c9d1e49b66ac53b (patch)
treef132c9857ae07ad31129ad2072647e894ab1bcc7
parent55a654dfcabe44ab8a9b416861aa474791b6bff3 (diff)
parent5e7674d1f97032ba45d925988b3e9c07a52e7078 (diff)
Merge pull request #83 from ShaunSHamilton/fix_title-height
fix(compile_assets): add title min-height
-rw-r--r--CHANGELOG.md1
-rw-r--r--book/book.toml2
-rw-r--r--compile_assets/scss/admonition.scss1
-rw-r--r--integration/book.toml2
-rw-r--r--integration/expected/book.toml2
-rw-r--r--src/bin/assets/VERSION2
-rw-r--r--src/bin/assets/mdbook-admonish.css1
7 files changed, 7 insertions, 4 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 56cbd83..ac8ff91 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@
### Fixed
- Custom installation and CSS directories are now normalized ([#49](https://github.com/tommilligan/mdbook-admonish/pull/49))
+- Fix title bars with no text rendering badly ([#83](https://github.com/tommilligan/mdbook-admonish/pull/83)), thanks to [@ShaunSHamilton](https://github.com/ShaunSHamilton)
## 1.8.0
diff --git a/book/book.toml b/book/book.toml
index ee415a9..4770288 100644
--- a/book/book.toml
+++ b/book/book.toml
@@ -14,4 +14,4 @@ assets_version = "2.0.0" # do not edit: managed by `mdbook-admonish install`
[output]
[output.html]
-additional-css = ["././mdbook-admonish.css"]
+additional-css = ["./mdbook-admonish.css"]
diff --git a/compile_assets/scss/admonition.scss b/compile_assets/scss/admonition.scss
index 78efdee..5d2588b 100644
--- a/compile_assets/scss/admonition.scss
+++ b/compile_assets/scss/admonition.scss
@@ -145,6 +145,7 @@ a.admonition-anchor-link {
// Admonition title
:is(.admonition-title, summary) {
position: relative;
+ min-height: 4rem;
margin-block: 0;
margin-inline: -1.6rem -1.2rem;
padding-block: 0.8rem;
diff --git a/integration/book.toml b/integration/book.toml
index 7abcfdb..5e0ae1f 100644
--- a/integration/book.toml
+++ b/integration/book.toml
@@ -9,7 +9,7 @@ title = "mdbook-admonish-integration"
[preprocessor.admonish]
command = "mdbook-admonish"
-assets_version = "2.0.0" # do not edit: managed by `mdbook-admonish install`
+assets_version = "2.0.1" # do not edit: managed by `mdbook-admonish install`
after = ["links"]
[output]
diff --git a/integration/expected/book.toml b/integration/expected/book.toml
index 7abcfdb..5e0ae1f 100644
--- a/integration/expected/book.toml
+++ b/integration/expected/book.toml
@@ -9,7 +9,7 @@ title = "mdbook-admonish-integration"
[preprocessor.admonish]
command = "mdbook-admonish"
-assets_version = "2.0.0" # do not edit: managed by `mdbook-admonish install`
+assets_version = "2.0.1" # do not edit: managed by `mdbook-admonish install`
after = ["links"]
[output]
diff --git a/src/bin/assets/VERSION b/src/bin/assets/VERSION
index 227cea2..38f77a6 100644
--- a/src/bin/assets/VERSION
+++ b/src/bin/assets/VERSION
@@ -1 +1 @@
-2.0.0
+2.0.1
diff --git a/src/bin/assets/mdbook-admonish.css b/src/bin/assets/mdbook-admonish.css
index 5e36038..244bc9a 100644
--- a/src/bin/assets/mdbook-admonish.css
+++ b/src/bin/assets/mdbook-admonish.css
@@ -77,6 +77,7 @@ a.admonition-anchor-link::before {
:is(.admonition-title, summary) {
position: relative;
+ min-height: 4rem;
margin-block: 0;
margin-inline: -1.6rem -1.2rem;
padding-block: 0.8rem;