diff options
author | Claire <claire.github-309c@sitedethib.com> | 2022-01-28 00:46:42 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-01-28 00:46:42 +0100 |
commit | e38fc319dc6897ca867a509b0c7a5878d34d0f00 (patch) | |
tree | a907ef55275a6d61a201cb0e31c61c75a3a8ffd4 /spec | |
parent | 03d59340da3ffc380d7b27169bdc887140d88bee (diff) |
Refactor and improve tests (#17386)
* Change account and user fabricators to simplify and improve tests
- `Fabricate(:account)` implicitly fabricates an associated `user` if
no `domain` attribute is given (an account with `domain: nil` is
considered a local account, but no user record was created), unless
`user: nil` is passed
- `Fabricate(:account, user: Fabricate(:user))` should still be possible
but is discouraged.
* Fix and refactor tests
- avoid passing unneeded attributes to `Fabricate(:user)` or
`Fabricate(:account)`
- avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other
way around
- prefer `Fabricate(:user, account_attributes: …)` to
`Fabricate(:user, account: Fabricate(:account, …)`
- also, some tests were using remote accounts with local user records, which is
not representative of production code.
Diffstat (limited to 'spec')