summaryrefslogtreecommitdiffstats
path: root/spec/lib
diff options
context:
space:
mode:
authorEugen Rochko <eugen@zeonfederated.com>2019-03-18 21:00:55 +0100
committerGitHub <noreply@github.com>2019-03-18 21:00:55 +0100
commit9c4cbdbafb0324ae259e10865b90ed1ed0255bdd (patch)
tree9d1d884fb1753f110683d7ff78912cdf868ec635 /spec/lib
parent42c581c45853cf08f2c9c521d59a2194ef2d9c61 (diff)
Add Keybase integration (#10297)
* create account_identity_proofs table * add endpoint for keybase to check local proofs * add async task to update validity and liveness of proofs from keybase * first pass keybase proof CRUD * second pass keybase proof creation * clean up proof list and add badges * add avatar url to keybase api * Always highlight the “Identity Proofs” navigation item when interacting with proofs. * Update translations. * Add profile URL. * Reorder proofs. * Add proofs to bio. * Update settings/identity_proofs front-end. * Use `link_to`. * Only encode query params if they exist. URLs without params had a trailing `?`. * Only show live proofs. * change valid to active in proof list and update liveness before displaying * minor fixes * add keybase config at well-known path * extremely naive feature flagging off the identity proof UI * fixes for rubocop * make identity proofs page resilient to potential keybase issues * normalize i18n * tweaks for brakeman * remove two unused translations * cleanup and add more localizations * make keybase_contacts an admin setting * fix ExternalProofService my_domain * use Addressable::URI in identity proofs * use active model serializer for keybase proof config * more cleanup of keybase proof config * rename proof is_valid and is_live to proof_valid and proof_live * cleanup * assorted tweaks for more robust communication with keybase * Clean up * Small fixes * Display verified identity identically to verified links * Clean up unused CSS * Add caching for Keybase avatar URLs * Remove keybase_contacts setting
Diffstat (limited to 'spec/lib')
-rw-r--r--spec/lib/proof_provider/keybase/verifier_spec.rb82
1 files changed, 82 insertions, 0 deletions
diff --git a/spec/lib/proof_provider/keybase/verifier_spec.rb b/spec/lib/proof_provider/keybase/verifier_spec.rb
new file mode 100644
index 00000000000..4ce67da9c56
--- /dev/null
+++ b/spec/lib/proof_provider/keybase/verifier_spec.rb
@@ -0,0 +1,82 @@
+require 'rails_helper'
+
+describe ProofProvider::Keybase::Verifier do
+ let(:my_domain) { Rails.configuration.x.local_domain }
+
+ let(:keybase_proof) do
+ local_proof = AccountIdentityProof.new(
+ provider: 'Keybase',
+ provider_username: 'cryptoalice',
+ token: '11111111111111111111111111'
+ )
+
+ described_class.new('alice', 'cryptoalice', '11111111111111111111111111')
+ end
+
+ let(:query_params) do
+ "domain=#{my_domain}&kb_username=cryptoalice&sig_hash=11111111111111111111111111&username=alice"
+ end
+
+ describe '#valid?' do
+ let(:base_url) { 'https://keybase.io/_/api/1.0/sig/proof_valid.json' }
+
+ context 'when valid' do
+ before do
+ json_response_body = '{"status":{"code":0,"name":"OK"},"proof_valid":true}'
+ stub_request(:get, "#{base_url}?#{query_params}").to_return(status: 200, body: json_response_body)
+ end
+
+ it 'calls out to keybase and returns true' do
+ expect(keybase_proof.valid?).to eq true
+ end
+ end
+
+ context 'when invalid' do
+ before do
+ json_response_body = '{"status":{"code":0,"name":"OK"},"proof_valid":false}'
+ stub_request(:get, "#{base_url}?#{query_params}").to_return(status: 200, body: json_response_body)
+ end
+
+ it 'calls out to keybase and returns false' do
+ expect(keybase_proof.valid?).to eq false
+ end
+ end
+
+ context 'with an unexpected api response' do
+ before do
+ json_response_body = '{"status":{"code":100,"desc":"wrong size hex_id","fields":{"sig_hash":"wrong size hex_id"},"name":"INPUT_ERROR"}}'
+ stub_request(:get, "#{base_url}?#{query_params}").to_return(status: 200, body: json_response_body)
+ end
+
+ it 'swallows the error and returns false' do
+ expect(keybase_proof.valid?).to eq false
+ end
+ end
+ end
+
+ describe '#status' do
+ let(:base_url) { 'https://keybase.io/_/api/1.0/sig/proof_live.json' }
+
+ context 'with a normal response' do
+ before do
+ json_response_body = '{"status":{"code":0,"name":"OK"},"proof_live":false,"proof_valid":true}'
+ stub_request(:get, "#{base_url}?#{query_params}").to_return(status: 200, body: json_response_body)
+ end
+
+ it 'calls out to keybase and returns the status fields as proof_valid and proof_live' do
+ expect(keybase_proof.status).to include({ 'proof_valid' => true, 'proof_live' => false })
+ end
+ end
+
+ context 'with an unexpected keybase response' do
+ before do
+ json_response_body = '{"status":{"code":100,"desc":"missing non-optional field sig_hash","fields":{"sig_hash":"missing non-optional field sig_hash"},"name":"INPUT_ERROR"}}'
+ stub_request(:get, "#{base_url}?#{query_params}").to_return(status: 200, body: json_response_body)
+ end
+
+ it 'raises a ProofProvider::Keybase::UnexpectedResponseError' do
+ expect { keybase_proof.status }.to raise_error ProofProvider::Keybase::UnexpectedResponseError
+ end
+ end
+ end
+end