summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRenaud Chaput <renchap@gmail.com>2023-07-28 19:11:58 +0200
committerClaire <claire.github-309c@sitedethib.com>2023-07-31 14:33:06 +0200
commit2fc6117d1b5643c0de908706d22702a35388a2a4 (patch)
treec4fff4251f78cd5ec7a47217afd578b5c9f9ef4b
parent2eb1a5b7b6d8b6a0b9426e7ee5a1fd04519dd7e2 (diff)
Fix missing return values in streaming (#26233)
-rw-r--r--streaming/index.js8
1 files changed, 5 insertions, 3 deletions
diff --git a/streaming/index.js b/streaming/index.js
index 1913be81f6c..3fea71f9445 100644
--- a/streaming/index.js
+++ b/streaming/index.js
@@ -724,7 +724,7 @@ const startWorker = async (workerId) => {
}
// If the payload already contains the `filtered` property, it means
- // that filtering has been applied on the ruby on rails side, as
+ // that filtering has been applied on the ruby on rails side, as
// such, we don't need to construct or apply the filters in streaming:
if (Object.prototype.hasOwnProperty.call(payload, "filtered")) {
transmit(event, payload);
@@ -796,12 +796,12 @@ const startWorker = async (workerId) => {
const filter_results = Object.values(req.cachedFilters).reduce((results, cachedFilter) => {
// Check the filter hasn't expired before applying:
if (cachedFilter.expires_at !== null && cachedFilter.expires_at < now) {
- return;
+ return results;
}
// Just in-case JSDOM fails to find textContent in searchableContent
if (!searchableTextContent) {
- return;
+ return results;
}
const keyword_matches = searchableTextContent.match(cachedFilter.regexp);
@@ -816,6 +816,8 @@ const startWorker = async (workerId) => {
status_matches: null
});
}
+
+ return results;
}, []);
// Send the payload + the FilterResults as the `filtered` property