summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorvalerauko <vale@valerauko.net>2018-11-22 20:49:07 +0900
committerEugen Rochko <eugen@zeonfederated.com>2018-11-23 22:16:13 +0100
commit12bdd7dc5f05e1b9eecf3b56dbcc24cf77bee884 (patch)
treec5e1743edb453ad168cbe90ed72266f2b0515734
parent15dcb414bf2faaf21a686aa467015d244743c04e (diff)
Ignore JSON-LD profile in mime type comparison (#9179)
Ignore JSON-LD profile in mime type comparison
-rw-r--r--app/services/fetch_atom_service.rb4
-rw-r--r--spec/services/fetch_atom_service_spec.rb11
2 files changed, 11 insertions, 4 deletions
diff --git a/app/services/fetch_atom_service.rb b/app/services/fetch_atom_service.rb
index 550e75f3344..d6508a9888a 100644
--- a/app/services/fetch_atom_service.rb
+++ b/app/services/fetch_atom_service.rb
@@ -29,7 +29,7 @@ class FetchAtomService < BaseService
def perform_request(&block)
accept = 'text/html'
- accept = 'application/activity+json, application/ld+json, application/atom+xml, ' + accept unless @unsupported_activity
+ accept = 'application/activity+json, application/ld+json; profile="https://www.w3.org/ns/activitystreams", application/atom+xml, ' + accept unless @unsupported_activity
Request.new(:get, @url).add_headers('Accept' => accept).perform(&block)
end
@@ -39,7 +39,7 @@ class FetchAtomService < BaseService
if response.mime_type == 'application/atom+xml'
[@url, { prefetched_body: response.body_with_limit }, :ostatus]
- elsif ['application/activity+json', 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"'].include?(response.mime_type)
+ elsif ['application/activity+json', 'application/ld+json'].include?(response.mime_type)
body = response.body_with_limit
json = body_to_json(body)
if supported_context?(json) && equals_or_includes_any?(json['type'], ActivityPub::FetchRemoteAccountService::SUPPORTED_TYPES) && json['inbox'].present?
diff --git a/spec/services/fetch_atom_service_spec.rb b/spec/services/fetch_atom_service_spec.rb
index 30e5b0935a3..495540004e9 100644
--- a/spec/services/fetch_atom_service_spec.rb
+++ b/spec/services/fetch_atom_service_spec.rb
@@ -60,8 +60,15 @@ RSpec.describe FetchAtomService, type: :service do
it { is_expected.to eq [url, { :prefetched_body => "" }, :ostatus] }
end
- context 'content_type is json' do
- let(:content_type) { 'application/activity+json' }
+ context 'content_type is activity+json' do
+ let(:content_type) { 'application/activity+json; charset=utf-8' }
+ let(:body) { json }
+
+ it { is_expected.to eq [1, { prefetched_body: body, id: true }, :activitypub] }
+ end
+
+ context 'content_type is ld+json with profile' do
+ let(:content_type) { 'application/ld+json; profile="https://www.w3.org/ns/activitystreams"' }
let(:body) { json }
it { is_expected.to eq [1, { prefetched_body: body, id: true }, :activitypub] }