diff options
author | Matt Jankowski <matt@jankowski.online> | 2024-01-11 10:13:11 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-01-11 15:13:11 +0000 |
commit | 2954279e9c630a9d146575bf600978dc6c5279bd (patch) | |
tree | 78128c6ccead27d159e53552b32b008df0359536 | |
parent | 95bd46d32afaaccc78762f7fc9c6428c4880cbc0 (diff) |
Remove double subject call in `api/v1/admin/trends/links/links` spec (#28695)
-rw-r--r-- | spec/requests/api/v1/admin/trends/links/links_spec.rb | 19 |
1 files changed, 10 insertions, 9 deletions
diff --git a/spec/requests/api/v1/admin/trends/links/links_spec.rb b/spec/requests/api/v1/admin/trends/links/links_spec.rb index 05020b0fd06..48842828b32 100644 --- a/spec/requests/api/v1/admin/trends/links/links_spec.rb +++ b/spec/requests/api/v1/admin/trends/links/links_spec.rb @@ -32,18 +32,18 @@ describe 'Links' do it_behaves_like 'forbidden for wrong role', '' it 'returns http success' do - subject + expect { subject } + .to change_link_trendable_to_true expect(response).to have_http_status(200) + expects_correct_link_data end - it 'sets the link as trendable' do - expect { subject }.to change { preview_card.reload.trendable }.from(false).to(true) + def change_link_trendable_to_true + change { preview_card.reload.trendable }.from(false).to(true) end - it 'returns the link data' do - subject - + def expects_correct_link_data expect(body_as_json).to match( a_hash_including( url: preview_card.url, @@ -85,13 +85,14 @@ describe 'Links' do it_behaves_like 'forbidden for wrong role', '' it 'returns http success' do - subject + expect { subject } + .to_not change_link_trendable expect(response).to have_http_status(200) end - it 'does not set the link as trendable' do - expect { subject }.to_not(change { preview_card.reload.trendable }) + def change_link_trendable + change { preview_card.reload.trendable } end it 'returns the link data' do |