From 866e48b0994c6338e6aa4ae7c413b5888ab432d1 Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Wed, 27 Apr 2016 16:19:26 +0800 Subject: spi: pic32: Fix checking return value of devm_ioremap_resource devm_ioremap_resource() returns ERR_PTR on error. Also remove the redundant dev_err message, the implementation of devm_ioremap_resource() already print error messages on error paths. Signed-off-by: Axel Lin Signed-off-by: Mark Brown --- drivers/spi/spi-pic32.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'drivers/spi/spi-pic32.c') diff --git a/drivers/spi/spi-pic32.c b/drivers/spi/spi-pic32.c index 4eeb8a85b030..73db87f805a1 100644 --- a/drivers/spi/spi-pic32.c +++ b/drivers/spi/spi-pic32.c @@ -711,10 +711,9 @@ static int pic32_spi_hw_probe(struct platform_device *pdev, mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); pic32s->regs = devm_ioremap_resource(&pdev->dev, mem); - if (!pic32s->regs) { - dev_err(&pdev->dev, "ioremap() failed\n"); - return -ENOMEM; - } + if (IS_ERR(pic32s->regs)) + return PTR_ERR(pic32s->regs); + pic32s->dma_base = mem->start; /* get irq resources: err-irq, rx-irq, tx-irq */ -- cgit v1.2.3