summaryrefslogtreecommitdiffstats
path: root/drivers/staging/vt6655
AgeCommit message (Collapse)Author
2015-02-07staging: vt6655: vnt_rx_data add track rsr and new_rsr errorsMalcolm Priestley
If not rsr & RSR_CRCOK report RX_FLAG_FAILED_FCS_CRC If not rsr & (RSR_IVLDTYP | RSR_IVLDLEN) drop packet If not NEWRSR_DECRYPTOK on new_rsr drop packet. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-02-07staging: vt6655: Fix TD_FLAGS_NETIF_SKB only on TYPE_AC0DMAMalcolm Priestley
Allow only TD_FLAGS_NETIF_SKB on ring buffer TYPE_AC0DMA for data only transfers for correct reporting of tx rates. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-02-07staging: vt6655: parse bb vga code out of device_intr.Malcolm Priestley
Reordering the code and reversing the priv->byBBVGANew verses priv->byBBVGACurrent check and using dev_dbg for pr_debug. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-02-07staging: vt6655: move setting of PSTxDesc->buff_addr to vnt_tx_packetMalcolm Priestley
Keep setting of this part of the structure with the others. Only pTDInfo needs carried in the buffer structure. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-28staging: vt6655: fix that open brace { should be on the previous lineMariam Mohamed Fawzy
This patch fixes the following checkpatch.pl error: fix that open brace { should be on the previous line Signed-off-by: Mariam Mohamed Fawzy <maryammohamed61@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: vt6655: RFbSetPower remove unused variable byPwrdBmMalcolm Priestley
byPwrdBm is set but never used. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: vt6655: Fix RFbSetPower() error: buffer overflow ↵Malcolm Priestley
'priv->abyCCKPwrTbl' 15 <= 56 Check uCH is not more than CB_MAX_CHANNEL_24G(14) on rates RATE_1M to RATE_11M Return false as the call is invalid as these rates do not exist above channel 14. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: vt6655: device_init_registers alway set initial antenna modeMalcolm Priestley
BBvSetTxAntennaMode and BBvSetRxAntennaMode need to be set correcty on start up Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: vt6655: remove antenna diversity functionsMalcolm Priestley
The vendor had disabled these functions in their last version. On test this can be troublesome, so remove this from the driver along with its macros and timers. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: vt6655: common variable size channel numbers to ↵Malcolm Priestley
ieee80211_channel->hw_value hw_value is u16 so fix all to the same size. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: vt6655: set_channel replace parameter with ieee80211_channelMalcolm Priestley
replacing uConnectionChannel for hw_value as set in vnt_init_bands. This allows other signaling of ieee80211_channel to move deeper into driver. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: vt6655: fix space prohibted before that ','Ahmad Hassan
This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' Signed-off-by: Ahmad Hassan <ahmad.hassan612@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: vt6655: fix space prohibited before that ','Heba Aamer
This patch fixes the following checkpatch.pl error: fix space prohibited before that ',' Signed-off-by: Heba Aamer <heba93aamer@gmail.com> Reviewed-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-19Merge 3.19-rc5 into staging-nextGreg Kroah-Hartman
We want the staging fixes in this branch as well. Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17Staging: vt6655: Checkpatch fix: c99 comment headingsEmrys Bayliss
This patch fixes some of the following checkpatch.pl errors in mac.h ERROR: do not use C99 // comments This patch reformats all single line c99 style comments to the preferred style. Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17Staging: vt6655: comment headings formattingEmrys Bayliss
This patch makes the formatting of the comments in mac.h more consistent. * Where a heading takes up three comment lines it is reduced to one. * A newline always separates column headings Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17Staging: vt6655: Checkpatch fix: lines longer than 80 columnsEmrys Bayliss
This patch fixes the following checkpatch.pl errors in mac.h: WARNING: line over 80 characters Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17Staging: vt6655: Checkpatch fix: c99 comments after statementsEmrys Bayliss
This patch fixes some c99 errors in mac.h: ERROR: do not use C99 // comments All instances where the c99 comment occurs after a statement. Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17Staging: vt6655: comment after statement formattingEmrys Bayliss
This patch makes the formatting of the comments in mac.h more consistent. * Where a comment follows a statement, it is separated by a single space. Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17Staging: vt6655: Checkpatch fix: empty c99 commentsEmrys Bayliss
This patch fixes some of the following checkpatch.pl errors in mac.h: ERROR: do not use C99 // comments This patch truncates statements which are followed by empty c99 comments. Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17Staging: vt6655: Checkpatch fix: unnecessary whitespaceEmrys Bayliss
This patch fixes the following checkpatch.pl errors in mac.h: ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12staging: vt6655: fix sparse warning: argument typeEddie Kovsky
Fixes following warning generated by sparse: drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/baseband.c:2180:45: expected struct vnt_private *priv drivers/staging/vt6655/baseband.c:2180:45: got void [noderef] <asn:2>*dwIoBase Compile tested on next-20141219. Signed-off-by: Eddie Kovsky <ewk@edkovsky.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12staging: vt6655: Fix loss of distant/weak access points on channel change.Malcolm Priestley
If the asssocated access point is strong byBBVGACurrent will be adjusted accordingly. Users will nolonger see distant access points without taking down interface. When changing channel reset byBBVGACurrent back to pDevice->abyBBVGA[0] for max sensitivity. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12staging: vt6655: vnt_tx_packet Fix corrupted tx packets.Malcolm Priestley
Move PSTxDesc->m_td1TD1 to inside spin locks. if m_td1TD1.byTCR has TCR_EDP and TCR_STP are set, the interrupt handler will try and complete the buffer before it is completed. Usually on the tail of a burst of tx packets. This results in a partially completed packet being transmitted or worse sitll dead lock when skb is freed by the interrupt handler. Set head_td->m_td1TD1.byTCR to 0 in first lock of vnt_tx_packet to stop interrupt handler completing the buffer. Move Set TSR1 & ReqCount in s_cbFillTxBufHead to the second lock. cbReqCount is carried to the second lock in pTDInfo->dwReqCount without the padding removed. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12staging: vt6655: fix sparse warnings: incorrect argument typeMike Krinkin
this patch fixes following sparse warnings: drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident> drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces) drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident> drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident> drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private * drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces) drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident> drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private * Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12Staging: vt6655: Fixed a typoGustavo A. R. Silva
Fixed a typo in mac.c file. Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12staging: vt6655: [BUG] Protect MACvSelectPage1 with lock.Malcolm Priestley
The device must not flip to page 1 while in interrupt lock causing loss of connection or dead lock. Protect from changes to page by adding lock where user can change the page in CARDvSetRSPINF, vnt_configure and set_channel Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12Staging: vt6655: fix a space coding style issuePiotr Kubus
Fixed a space coding style issue found by checkpatch.pl in rxtx.c. Signed-off-by: Piotr Kubus <p.t.kubus@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12Staging: vt6655: baseband.c: fixed line over 80 charactersSakshi Bansal
Signed-off-by: Sakshi Bansal <sakshi.april5@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12staging: vt6655: Replace C99 comments in power.c and upc.h.Nicholas Parkanyi
This patch fixes the following checkpatch.pl warnings: ERROR: do not use C99 // comments +// ERROR: do not use C99 // comments +// For memory mapped IO ERROR: do not use C99 // comments +// ERROR: do not use C99 // comments +#endif // __UPC_H__ ERROR: do not use C99 // comments + // set period of power up before TBTT ERROR: do not use C99 // comments + // set AID ERROR: do not use C99 // comments + // set ATIM Window ERROR: do not use C99 // comments + // Set AutoSleep ERROR: do not use C99 // comments + // Set HWUTSF ERROR: do not use C99 // comments + // clear always listen beacon ERROR: do not use C99 // comments + // first time set listen next beacon ERROR: do not use C99 // comments + // always listen beacon ERROR: do not use C99 // comments + // enable power saving hw function ERROR: do not use C99 // comments + // disable power saving hw function ERROR: do not use C99 // comments + //clear AutoSleep ERROR: do not use C99 // comments + //clear HWUTSF ERROR: do not use C99 // comments + // set always listen beacon Signed-off-by: Nicholas Parkanyi <n.parkanyi@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12staging: vt6655: remove unused function in mac.cFred Chou
Removed the unused function MACvGetShortRetryLimit, which also fixed the following sparse warning: drivers/staging/vt6655/mac.c:162:6: warning: symbol 'MACvGetShortRetryLimit' was not declared. Should it be static? Signed-off-by: Fred Chou <fred.chou.nd@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-12staging: vt6655: Declare vnt_init() staticSören Brinkmann
Fix sparse warning: drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static? Signed-off-by: Sören Brinkmann <soeren.brinkmann@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-12-02staging: vt6655: s_cbFillTxBufHead remove parameter cbFrameBodySizeMalcolm Priestley
skb->len is available locally use that instead. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-12-02staging: vt6655: s_cbFillTxBufHead remove parameter *pPacketMalcolm Priestley
skb->data is available locally so use that instead. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-12-02staging: vt6655: s_cbFillTxBufHead remove unused parameter *puMACfragNumMalcolm Priestley
*puMACfragNum was part of old legacy functions. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-12-02staging: vt6655: remove unused typedef struct tagSSromRegMalcolm Priestley
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-12-02staging: vt6655: srom remove dead functionsMalcolm Priestley
Remove these unused functions SROMbWriteEmbedded SROMvRegBitsOn SROMvRegBitsOff SROMbIsRegBitsOn SROMbIsRegBitsOff SROMvWriteAllContents SROMvWriteEtherAddress SROMvReadSubSysVenId SROMbAutoLoad Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-12-02staging: vt6655: remove duplicate MACvSetPacketFilterMalcolm Priestley
Packet filtering is already done in vnt_configure. A call to MACvSetPacketFilter is not necessary in MACvInitialize as this will be done by vnt_configure when interface is up. Also remove macros associated with this function. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf.c clean up function commentsMalcolm Priestley
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf.c Removed unneeded commentsMalcolm Priestley
Type and function that are not present comments Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf.c: Remove author commentsMalcolm Priestley
Moving names to file header comment Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf.c camel calse vnt_private rename pDevice to privMalcolm Priestley
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: IFRFbWriteEmbedded replace __iomem with vnt_privateMalcolm Priestley
Fixing callers to vnt_private Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: rf remove __iomem *dwIoBase from functionsMalcolm Priestley
replacing with vnt_private and removing dereferencing from callers Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: card.c move __iomem into functions.Malcolm Priestley
Removing dereferencing from callers Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: card Remove function vUpdateIFSMalcolm Priestley
vUpdateIFS does the same operations of CARDbSetPhyParameter there is not need to call this function. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: always keep abyCurrentNetAddr aligned to 2Malcolm Priestley
Because the driver now uses ether_addr_copy the alignment of this variable must be maintained at 2. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: change typedef enum _VIA_PKT_TYPE to macroMalcolm Priestley
Replacing for u8 type and removing cast for byBBType. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: replace typedef enum _VIA_BB_TYPE with macrosMalcolm Priestley
Replacing type with u8 Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-11-26staging: vt6655: CARDbSetPhyParameter remove unused parametersMalcolm Priestley
wCapInfo byERPField, *pvSupportRateIEs *pvExtSupportRateIEs Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>