summaryrefslogtreecommitdiffstats
path: root/drivers/staging/unisys
AgeCommit message (Collapse)Author
2015-02-07staging: unisys: Fix typo in commentBastien Nocera
Signed-off-by: Bastien Nocera <hadess@hadess.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-02-07staging/unisys/visorutil/procobjecttree: Replace typedefRicardo Ribalda Delgado
Instead of declaring a new type, define a new struct. Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-02-07staging/unisys/visorutil/procobjecttree: Code StyleRicardo Ribalda Delgado
Lines should not be over 80 characters Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-02-07staging: unisys: use msecs_to_jiffies for conversionsNicholas Mc Guire
This is only an API consolidation to make things more readable. Instances of var * HZ / 1000 are replaced by msecs_to_jiffies(var). Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-28drivers/staging: use current->state helpersDavidlohr Bueso
Call __set_current_state() instead of assigning the new state directly. These interfaces also aid CONFIG_DEBUG_ATOMIC_SLEEP environments, keeping track of who changed the state. Signed-off-by: Davidlohr Bueso <dbueso@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-28staging: unisys: rework signal remove/insert to avoid sparse lock warningsZachary Warren
Avoids the following warnings from sparse: visorchannel_funcs.c:457:9: warning: context imbalance in 'visorchannel_signalremove' - different lock contexts for basic block visorchannel_funcs.c:512:9: warning: context imbalance in 'visorchannel_signalinsert' - different lock contexts for basic These warnings are false positives. Sparse can't track conditional contexts. The change puts the lock/unlock into the same context by splitting the insert/remove functions each into a wrapper function that does locking if necessary and an inner function that does the insert/remove operation. Signed-off-by: Zachary Warren <conflatulence@gmail.com> Acked-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: fix CamelCase in enable_ints_write()Benjamin Romer
Fix CamelCase variable name: Features_addr => features_addr Update references to use the new name. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: fix CamelCase name in virthba_probe()Benjamin Romer
Fix CamelCase local variable name: pChannelHeader => channel_header Update references to use the new name. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: refactor virthba_ISR()Benjamin Romer
Fix CamelCase names: virthba_ISR => virthba_isr pChannelHeader => channel_header Update all references to the modified names. Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Fix CamelCase for function names in virthba.cKen Depro
This patch fixes CamelCase function names in virthba.c, reported by the checkpatch script: doDiskAddRemove --> do_disk_add_remove SendDiskAddRemove --> send_disk_add_remove Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Fix remaining CamelCase global variables in virthba.cKen Depro
This patch fixes the remaining CamelCase global variables in virthba.c reported by the checkpatch script: MaxBuffLen --> max_buff_len VirtHbasOpen --> virthbas_open Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Fix CamelCase for Disk Add/Remove global variables in virthba.cKen Depro
This patch fixes the Disk Add/Remove (DAR) related CamelCase global variables in virthba.c, reported by the checkpatch script: DARWorkQ --> dar_work_queue DARWorkQHead --> dar_work_queue_head DARWorkQLock --> dar_work_queue_lock DARWorkQSched --> dar_work_queue_sched Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Fix open parenthesis alignment issues in virthba.cKen Depro
This patch fixes a couple checkpatch checks where alignment of the parameters did not match the open parenthesis of the function. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Fix warnings regarding lines over 80 characters in virthba.cKen Depro
This patch fixes warnings generated by checkpatch script regarding lines over 80 characters long. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Fix "else not useful after return" warning in virthba.cKen Depro
This patch fixes a warning generated during the checkpatch script that stated "else not useful after return". I modified the code to return a designated status at the end of the function, and replaced the return statement in the "else if" to set the status accordingly. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: fix checkpatch checks for structs in virthba.cKen Depro
This patch fixes a couple small issues reported by the checkpatch script: Adds a blank line after a struct definition. Removes unnecessary parentheses surrounding a dereference of a struct member. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Change alloc calls to use var name instead of type in virthba.cKen Depro
This patch changes a couple of kzalloc calls to pass the variable name to the call, rather than the variable struct type. This is a result of checks generated during the checkpatch script. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Remove blank lines before/after braces in virthba.cKen Depro
This patch removes unnecessary blank lines either before opening braces or after closing braces, as reported by the checkpatch script. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Fix logical continuation checks in virthba.cKen Depro
This patch fixes checkpatch checks where the logical operator should be at the end of the line above, not beginning the next line. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Fix open parenthesis alignment checks in virthba.cKen Depro
This patch fixes the "alignment should match open parenthesis" checks from the checkpatch script. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-25staging: unisys: Remove unneeded spaces after casts in virthba.cKen Depro
This patch removes all unnecessary spaces after casts, as reported by the checkpatch script. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-17staging: virtpci: Remove no-op suspend/resume functionsLars-Peter Clausen
The virtpci bus driver still uses the legacy suspend/resume callbacks. In their current implementation these callbacks only contain a macro that always expands to 'do { } while(0)'. So instead of converting them to dev PM ops just remove them. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix checkpatch space prohibited before comma errorsSyed Amer Gilani
Fixes checkpatch Error: ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Syed Amer Gilani <syed.amer@gilani.eu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: uislib: uisutils.c: Fix a missing va_endRickard Strandqvist
A missing va_end in connection with vsnprintf Was found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: virtpci: virtpci.c: Removes unnecessary NULL checkRickard Strandqvist
It is impossible for dprivate to ever be NULL, no check required. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: remove leftover __DATE__Rasmus Villemoes
Commit 836bee9eee6d ("Staging: unisys: remove references to __DATE__ and __TIME__") removed most; this seems to be an accidental leftover. VERSIONDATE is not used anywhere. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: Remove VISORCHANNEL typedefBryan Thompson
Remove the VISORCHANNEL typedef and rename the base VISORCHANNEL_Tag structure to visorchannel to follow consistent naming. The longer struct visorchannel type required additional line wrapping to remain less than 81 characters. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: visorchannel: Describe spinlocks in VISORCHANNEL_Tag structBryan Thompson
Add comments indicating the requirements and use of the insert_lock and remove_lock in the VISORCHANNEL_Tag structure. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: visorchannel: Rename CamelCase variable nQueuesBryan Thompson
Rename the visorchannel_debug parameter nQueues to num_queues. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: visorchannel: Rename CamelCase variable channelBytesBryan Thompson
Rename channelBytes to channel_bytes in the series of visorchannel_create functions provided by visorchannel. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: get rid of goto in visorchipset_ioctl()Benjamin Romer
Remove another completely unnecessary goto and just return the values directly. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix CamelCase in visorchipset_mmap()Benjamin Romer
Fix CamelCase name: physAddr => physaddr Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: get rid of goto in visorchipset_open()Benjamin Romer
This goto uses CamelCase and was completely unnecessary. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: get rid of HAVE_UNLOCKED_IOCTL codeBenjamin Romer
We definitely have it, so there's no point in keeping the older stuff around. Get rid of the #ifdefs and old code. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix CamelCase global variables in file.cBenjamin Romer
Fix CamelCase names: Cdev => file_cdev PControlVm_channel => file_controlvm_channel MajorDev => majordev Registered => registered Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: refactor visorchipset_file_init()Benjamin Romer
Fix the declaration so it is a single line. Fix CamelCase parameter names: MajorDev => major_dev pControlVm_channel => controlvm_channel Remove the unnecessary gotos and just return directly in error cases. Fix the last error condition so it returns the result of cdev_add() instead of always zero. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: refactor req_handler_add()Benjamin Romer
Fix the CamelCase parameter names: Server_Channel_Ok => server_channel_ok Server_Channel_Init => server_channel_init clientStr => clientstr clientStrLen => clientstr_len And remove the extra parenthesis in the list_add_tail() call at the end. Signed-off-by: Ken Depro <kenneth.depro@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix CamelCase globals in uisutils.cBenjamin Romer
Rename CamelCase global variable names: ReqHandlerInfo_list => req_handler_info_list ReqHandlerInfo_list_lock => req_handler_info_list_lock Update all references to use the new name. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: refactor uisctrl_unregister_req_handler_ex()Benjamin Romer
Get rid of the unnecessary goto statement and just return directly. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: refactor uisctrl_register_req_handler_ex()Benjamin Romer
Fix CamelCase local variable name: pReqHandlerInfo => req_handler Get rid of the useless goto and just return straight away on an error. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix brackets in uisctrl_register_req_handler_ex()Benjamin Romer
Add the missing brackets to the last if statement in this function. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix spacing in uisutils.cBenjamin Romer
Fix as many spacing problems as possible by indenting lines properly and getting rid of spaces between typecasts and their targets. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix line spacing in uisutils.cBenjamin Romer
Just remove the couple of extra blank lines. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix line spacing in uisthread.cBenjamin Romer
Just remove the one extra blank line. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix CamelCase names in do_locked_client_insert()Benjamin Romer
Fix CamelCase names: pSignal => signal Remove unused parameters issueInterruptIfEmpty and interruptHandle, and update callers of this function. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix spacing in uisqueue.cBenjamin Romer
Correct alignment for a couple of functions and remove the space between a typecast and its target. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: fix CamelCase Work queue name in uislib.cBenjamin Romer
Fix CamelCase name: Work_wakeup_polling_device_channels => work_wakeup_polling_device_channels Update references to use the new name. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: rename Initialize_incoming_thread()Benjamin Romer
Fix the CamelCase name of this function: Initialize_incoming_thread => initialize_incoming_thread Update all references to use the new name. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: rename Process_Incoming()Benjamin Romer
Fix the CamelCase function name: Process_Incoming => process_incoming Update all references to use the new name. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2015-01-09staging: unisys: refactor find_dev()Benjamin Romer
Fix the function definition so that it is a single line. Fix CamelCase parameter names: busNo => bus_no devNo => dev_no Get rid of the goto and just break out of the for loop, since that does the exact same thing. Signed-off-by: Bryan Thompson <bryan.thompson@unisys.com> Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-09-11 21:26:45 +0000