summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2016-10-16Staging: media: lirc: Use unsigned int instead unsignedMihaela Muraru
This patch fixes a WARNING: Prefer 'unsigned int' to bare use of 'unsigned', found by checkpatch.pl. By fixing this the types of the parameters become more explicit. Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: media: omap4iss: Unnecessary KERN_ERRMihaela Muraru
This patch remove unnecessary KERN_ERR in WARN() within iss_csi2.c Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: cfg80211: Remove unnecessary parentheses around variablessayli karnik
The patch fixes the checkpatch.pl check: CHECK: Unnecessary parentheses around variable Signed-off-by: sayli karnik <karniksayli1995@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: Replace data type declaration with variable of same type ↵Sergio Paracuellos
in prism2sta.c sizeof(*var) instead of sizeof(struct XXX) is preferred. Fix them in prism2sta.c file. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: Replace data type declaration with variable of same type ↵Sergio Paracuellos
in p80211netdev.c sizeof(var) instead of sizeof(struct XXX) is preferred. Fix them in p80211netdev.c Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: Replace data type declaration with variable of same type ↵Sergio Paracuellos
in p80211conv.c sizeof(*var) instead of sizeof(struct XXX) is preferred. Fix it in p80211conv.c file. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: Replace data type declaration with variable of same type ↵Sergio Paracuellos
in hfa384x_usb.c sizeof(var) instead of sizeof(struct XXX) is preferred. Fix it in hfa384x_usb.c file. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: Replace data type declaration with variable of same type ↵Sergio Paracuellos
in cfg80211.c sizeof(var) instead of sizeof(struct XXX) is preferred. Fix it in cfg80211.c file. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: sm750fb: compress return logicElizabeth Ferdman
Using Coccinelle script, compress return logic to return a value directly rather than doing an assignment and returning the variable. Remove unnecessary variable declaration by hand. Coccinelle script: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: sm750fb: Merge ddk750_help.* into ddk750_chip.*.Elise Lennion
The file ddk750_help.c contained only one function declaration, so it was merged into ddk750_chip.c to simplify the driver. Also, ddk750_help.h was merged into ddk750_chip.h to keep consistency. With these changes a few global variables are removed and the function ddk750_set_mmio is rewritten, so its purpose in the code is clearer. Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: comedi: ni_mio_common: split out ao arming from ni_ao_inttrigSpencer E. Olson
AO device arming was previously done as a part of ni_ao_inttrig which is called as a result of the user calling comedi_internal_trigger. For start_src == TRIG_EXT, this does not make very much sense since external triggers should not conceptually need to be software triggered also. This patch splits out the arming functionality to allow arming to specifically and separately be done via the CONFIG_INSN_ARM ioctl command. In order to provide backwards compatibility, this patch also provides automatic arming if ni_ao_inttrig is simply called. Signed-off-by: Spencer E. Olson <olsonse@umich.edu> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: comedi: make constants slightly more consistentSpencer E. Olson
This makes INSN_CONFIG_DIO_{INPUT,OUTPUT,OPENDRAIN} simply be copies of the already-existing constants COMEDI_INPUT, COMEDI_OUTPUT, and COMEDI_OPENDRAIN. This change also ensures that if a user happens to use, for example, COMEDI_INPUT in place of where INSN_CONFIG_DIO_INPUT, the result will always be the same and also acceptable and correct usage. Signed-off-by: Spencer E. Olson <olsonse@umich.edu> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: comedi: porting NI_GPCT constants from comedi.org moduleSpencer E. Olson
Information pertaining to the NI_GPCT_ARM* registers were added to the comedi.org version of the comedi kernel. This adds this information to the staging-tree version of the comedi kernel. Relevant comments are also copied over. Signed-off-by: Spencer E. Olson <olsonse@umich.edu> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: fbtft: Fix too many leading tabs warningGustavo A. R. Silva
This is a patch to the fb_agm1264k-fl.c file that fixes up the following issue: WARNING: Too many leading tabs - consider code refactoring Add new function iterate_diffusion_matrix() to refactor a piece of code inside write_vmem(). Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: fbtft: Convert int arrays to s16Joe Perches
These arrays use -1, -2, and -3 as initiators for various types of writes to initialize hardware. No values are used that conflict with using these arrays as s16 instead of int and reducing overall data is good. $ size drivers/staging/fbtft/built-in.o* text data bss dec hex filename 116120 32872 4152 153144 25638 drivers/staging/fbtft/built-in.o.new 116104 36344 6200 158648 26bb8 drivers/staging/fbtft/built-in.o.old Miscellaneous: o Realign some of the arrays to make reading a bit easier Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: vc04_services: fix up rpi firmware functionsGreg Kroah-Hartman
The raspberrypi-firmware.h file should provide empty functions if we aren't building in that option. This makes it easier to test-build code, and not have odd warnings about unused variables if you just try to #define away the functions. Cc: Daniel Stone <daniels@collabora.com> Cc: "Noralf Trønnes" <noralf@tronnes.org> Cc: Pranith Kumar <bobby.prani@gmail.com> Cc: popcornmix <popcornmix@gmail.com> Cc: Eric Anholt <eric@anholt.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: vc04_services: don't print pointers directlyGreg Kroah-Hartman
kernel pointers should be printed with %pK and are not unsigned int big on all architectures. So fix this up to get rid of a bunch of warning messages. Note, there are other assumptions in this code that a pointer fits into an int that need to be fixed up later. Cc: Daniel Stone <daniels@collabora.com> Cc: "Noralf Trønnes" <noralf@tronnes.org> Cc: Pranith Kumar <bobby.prani@gmail.com> Cc: popcornmix <popcornmix@gmail.com> Cc: Eric Anholt <eric@anholt.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: vc04_services: fix dmac_map/unmap_area prototypesGreg Kroah-Hartman
You don't define a function prototype on one line as a #define, and then the next declare it as an external C function, without expecting a C compiler to complain loudly. So fix up this mess. Cc: Daniel Stone <daniels@collabora.com> Cc: "Noralf Trønnes" <noralf@tronnes.org> Cc: Pranith Kumar <bobby.prani@gmail.com> Cc: popcornmix <popcornmix@gmail.com> Cc: Eric Anholt <eric@anholt.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: vc04_services: fix debugfs write functionsGreg Kroah-Hartman
write functions need to return ssize_t, not int, so fix the functions up for the correct prototype. Cc: Daniel Stone <daniels@collabora.com> Cc: "Noralf Trønnes" <noralf@tronnes.org> Cc: Pranith Kumar <bobby.prani@gmail.com> Cc: popcornmix <popcornmix@gmail.com> Cc: Eric Anholt <eric@anholt.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16drivers: staging: greybus: audio_codec.c: Fixed CHECKS for brace issuesChase Metzger
Added braces to else statement where checkpatch complained. Signed-off-by: Chase Metzger <chasemetzger15@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: rts5208: Remove unnecessary parenthesesDilek Uzulmez
Problem found using checkpatch.pl CHECK: Unnecessary parentheses around dev->dev_mutex Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: wilc1000: Unnecessary 'out of memory' messageMihaela Muraru
This patch fixes checkpatch.pl warning in file host_interface.c WARNING : possible unecessary 'out of memory' message. Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wilc1000: Replace printk() with pr_info().Elise Lennion
Fix checkpatch warning: WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... Replace printk(KERN_INFO...) by pr_info() for more uniform error reporting. Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: wilc1000: Remove unnecessary 'out of memory' message.Dilek Uzulmez
This patch fixes checkpatch.pl warning in file host_interface.c WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: media: cxd2099: Format block comments.Elise Lennion
Fix checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Elise Lennion <elise.lennion@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: i4l: remove parens around return statementElizabeth Ferdman
Remove parentheses surrounding return statements. Error found by checkpatch. changes made using coccinelle script: @@ expression e,e1; @@ ( return (e / e1); | return -( e -) ; ) Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: i4l: icn: Fixed open brace should be on previous line errorHarman Kalra
This patch resolves the following error caught by checkpatch.pl: ERROR: that open brace { should be on the previous line Signed-off-by: Harman Kalra <harman4linux@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: i4l: icn: prefer pr_* instead of printkHarman Kalra
This patch replaces call to printk with appropriate pr_* function thus addressing the following warning generated by the checkpatch script: Prefer [subsystem eg: netdev]_dbg([subsystem]dev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... Signed-off-by: Harman Kalra <harman4linux@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16Staging: i4l: icn: Fixed open brace should be on previous line errorHarman Kalra
This patch resolves the following error caught by checkpatch.pl: ERROR: that open brace { should be on the previous line Signed-off-by: Harman Kalra <harman4linux@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: net: netlogic: use new api ethtool_{get|set}_link_ksettingsPhilippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes <tremyfr@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in prism2mgmt.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in prism2mgmt.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in p80211req.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in p80211req.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in p80211netdev.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in p80211netdev.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in p80211msg.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in p80211msg.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in p80211mgmt.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in p80211mgmt.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in p80211metadef.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in p80211metadef.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in p80211ioctl.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in p80211ioctl.h Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in p80211hdr.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in p80211hdr.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comments style in p80211conv.hSergio Paracuellos
This patch fixes the following checkpatch.pl warning in p80211conv.h: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: use netdev_* instead of printk()Sabitha George
1. Fixes checkpatch warning on printk usage in ks_hostif.c 2. Dropped "ks_wlan" prefix from the messages 3. Removed the "Memory squeeze,dropping packet" messages Signed-off-by: Sabitha George <sabitha.george@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: fix space related style issues in ks7010_sdio.cAkshay Mariyanna
This fixes the following checkpatch warnings: WARNING: Unnecessary space before function pointer arguments WARNING: unnecessary whitespace before a quoted newline Signed-off-by: Akshay Mariyanna <akmlkcc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: ks7010: fix indent style in ks7010_sdio.cAkshay Mariyanna
This patch fixes the following checkpatch error: ERROR: code indent should use tabs where possible Signed-off-by: Akshay Mariyanna <akmlkcc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: get memory from kernel allocators instead of big static bufferSergio Paracuellos
This patch fix the following sparse warnings in prism2fw.c: warning: memset with byte count of 120000 Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: avoid new typedef CTLX_STATESergio Paracuellos
This patch fixes the following checkpatch.pl warning in hfa384x.h: WARNING: do not add new typedefs It applies for typedef CTLX_STATE Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comment warnings in prism2fw.cSergio Paracuellos
This patch fix the following checkpatch.pl warnings in prism2fw.c WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comment warnings in prism2sta.cSergio Paracuellos
This patch fix the following checkpatch.pl warnings in prism2sta.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comment warnings in prism2mib.cSergio Paracuellos
This patch fix the following checkpatch.pl warnings in prism2mib.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comment warnings in prism2mgmt.cSergio Paracuellos
This patch fix the following checkpatch.pl warnings in prism2mgmt.c: WARNING: Block comments should align the * on each line WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix line style warnings in p80211wep.cSergio Paracuellos
This patch fix the following checkpatch.pl warnings in p80211wep.c: WARNING: line over 80 characters Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2016-10-16staging: wlan-ng: fix block comment warnings in p80211wep.cSergio Paracuellos
This patch fix the following checkpatch.pl warnings in p80211wep.c: WARNING: Block comments should align the * on each line Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-31 23:05:37 +0000