diff options
author | Coly Li <colyli@suse.de> | 2020-02-01 22:42:32 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2020-02-01 07:55:39 -0700 |
commit | 7c02b0055f774ed9afb6e1c7724f33bf148ffdc0 (patch) | |
tree | 400d816b9ee231137868677997156fbca46f2a5d /drivers/md/bcache/sysfs.c | |
parent | 5bebf7486d4f4940b2a8e4009beb1dff5041853d (diff) |
bcache: explicity type cast in bset_bkey_last()
In bset.h, macro bset_bkey_last() is defined as,
bkey_idx((struct bkey *) (i)->d, (i)->keys)
Parameter i can be variable type of data structure, the macro always
works once the type of struct i has member 'd' and 'keys'.
bset_bkey_last() is also used in macro csum_set() to calculate the
checksum of a on-disk data structure. When csum_set() is used to
calculate checksum of on-disk bcache super block, the parameter 'i'
data type is struct cache_sb_disk. Inside struct cache_sb_disk (also in
struct cache_sb) the member keys is __u16 type. But bkey_idx() expects
unsigned int (a 32bit width), so there is problem when sending
parameters via stack to call bkey_idx().
Sparse tool from Intel 0day kbuild system reports this incompatible
problem. bkey_idx() is part of user space API, so the simplest fix is
to cast the (i)->keys to unsigned int type in macro bset_bkey_last().
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md/bcache/sysfs.c')
0 files changed, 0 insertions, 0 deletions