select: rust 1.34: str does not implement PartialOrd<String>, so use slice instead

1 files changed, 12 insertions, 2 deletions

diff --git a/src/actions/select.rs b/src/actions/select.rs
index 3ecda45..9cbbca4 100644
--- a/src/actions/select.rs
+++ b/src/actions/select.rs
@@ -38,13 +38,23 @@ impl SelectFilters {
 
 impl SelectFilterFrom {
   fn is_bucket_before(&self, bucketname: &str) -> bool {
-    self.bucket.as_ref().map_or(false, |bucket| bucketname < bucket)
+    // cargo check && cargo build are fine,
+    // cargo test gives this error:
+    // error[E0277]: can't compare `str` with `std::string::String`
+    //--> src/actions/select.rs:47:59
+    //|
+    //|     self.bucket.as_ref().map_or(true, |bucket| bucketname < bucket)
+    //|                                                           ^ no implementation for `str < std::string::String` and `str > std::string::String`
+    //|
+    //= help: the trait `std::cmp::PartialOrd<std::string::String>` is not implemented for `str`
+    //= note: required because of the requirements on the impl of `std::cmp::PartialOrd<&std::string::String>` for `&str`
+    self.bucket.as_ref().map_or(false, |bucket| bucketname < bucket.as_str())
   }
 }
 
 impl SelectFilterTo {
   fn is_bucket_while(&self, bucketname: &str) -> bool {
-    self.bucket.as_ref().map_or(true, |bucket| bucketname <= bucket)
+    self.bucket.as_ref().map_or(true, |bucket| bucketname <= bucket.as_str())
   }
 }