From 932e01b41ac3203b43ec786b8d9c25334e3e1623 Mon Sep 17 00:00:00 2001 From: Jesse Duffield Date: Thu, 20 Jul 2023 21:08:56 +1000 Subject: Add test for crashing on empty menu --- pkg/integration/tests/test_list.go | 1 + pkg/integration/tests/ui/empty_menu.go | 31 +++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+) create mode 100644 pkg/integration/tests/ui/empty_menu.go diff --git a/pkg/integration/tests/test_list.go b/pkg/integration/tests/test_list.go index caaf2039e..5eab827b7 100644 --- a/pkg/integration/tests/test_list.go +++ b/pkg/integration/tests/test_list.go @@ -211,6 +211,7 @@ var tests = []*components.IntegrationTest{ tag.Reset, ui.Accordion, ui.DoublePopup, + ui.EmptyMenu, ui.SwitchTabFromMenu, undo.UndoCheckoutAndDrop, undo.UndoDrop, diff --git a/pkg/integration/tests/ui/empty_menu.go b/pkg/integration/tests/ui/empty_menu.go new file mode 100644 index 000000000..d6b3b42f0 --- /dev/null +++ b/pkg/integration/tests/ui/empty_menu.go @@ -0,0 +1,31 @@ +package ui + +import ( + "github.com/jesseduffield/lazygit/pkg/config" + . "github.com/jesseduffield/lazygit/pkg/integration/components" +) + +var EmptyMenu = NewIntegrationTest(NewIntegrationTestArgs{ + Description: "Verify that we don't crash on an empty menu", + ExtraCmdArgs: []string{}, + Skip: false, + SetupConfig: func(config *config.AppConfig) {}, + SetupRepo: func(shell *Shell) { + }, + Run: func(t *TestDriver, keys config.KeybindingConfig) { + t.Views().Files(). + IsFocused(). + Press(keys.Universal.OptionMenu) + + t.Views().Menu(). + IsFocused(). + // a string that filters everything out + FilterOrSearch("ljasldkjaslkdjalskdjalsdjaslkd"). + IsEmpty(). + Press(keys.Universal.Select) + + // back in the files view, selecting the non-existing menu item was a no-op + t.Views().Files(). + IsFocused() + }, +}) -- cgit v1.2.3