Age | Commit message (Collapse) | Author | |
---|---|---|---|
2020-02-04 | Check cached when showing new file diffs | Glenn Vriesman | |
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com> | |||
2020-02-03 | correctly compare new main height to previous | Jesse Duffield | |
2020-02-02 | verify that VISUAL,EDITOR,LGCC envvars are set for non-interactive commandsv0.14 | Chris Taylor | |
2020-02-02 | add a helper to search a list for a pattern | Chris Taylor | |
2020-02-02 | perpetuate this style of dependency injection | Chris Taylor | |
2020-02-02 | make amend more non-interactive | Chris Taylor | |
2020-02-02 | more ticker improvements | Jesse Duffield | |
2020-02-01 | explicitly tell gocui when to start animating the loader | Jesse Duffield | |
2020-02-01 | only rerender app status when we need to | Jesse Duffield | |
2020-01-31 | close more things when switching repos or to a subprocess | Jesse Duffield | |
2020-01-31 | fix segfault on line by line panel | Jesse Duffield | |
The state object is sometimes undefined in the onclick method of the line by line panel. Because we set it to nil in a bunch of places, I've decided to just change the main context to 'normal' before setting it to nil anywhere. That way the keybindings for the line by line panel won't get executed and we won't get a segfault. | |||
2020-01-29 | handle files that were deleted downstream but modified upstream | Jesse Duffield | |
2020-01-29 | split main view vertically | Jesse Duffield | |
When staging lines (or doing anything that requires the main view to split into two) we want to split vertically if there's not much width available in the window. If there is enough width we will split horizontally. The aim here is to allow for sufficient room in the side panel. We might need to tweak this or make it configurable but I think it's set to a pretty reasonable default i.e. switching to split vertically when the window width falls under 220 | |||
2020-01-29 | safely unstage lines | Jesse Duffield | |
2020-01-29 | remove rollbar | Jesse Duffield | |
2020-01-29 | make use of branch config when pushing/pulling | Jesse Duffield | |
2020-01-28 | fix comment | Jesse Duffield | |
2020-01-28 | use reflog timestamps rather than commit timestamps to show commit recency | Jesse Duffield | |
2020-01-16 | handle case where file watcher is disabled | Jamie Brynes | |
2020-01-12 | handle when fsnotify doesn't work | Jesse Duffield | |
2020-01-12 | Missed a spot with this new string task thing | Jesse Duffield | |
The issue here was that we were using a string task but expecting to be able to set the origin straight after to point at the conflict, but because it's async it was actually resetting the origin to 0 after a little bit. The proper solution here is maybe to add a flag to that thing asking whether you want to reset main's origin. But I'm too lazy to do that right now so instead I'm just using setViewContent. That will probably cause issues in the future. | |||
2020-01-12 | reset origin when clicking on list item | Jesse Duffield | |
2020-01-12 | use view line height to see if you should stop scrolling | Jesse Duffield | |
2020-01-12 | keep track of current view when pushing | Jesse Duffield | |
2020-01-12 | allow fast flicking through any list panel | Jesse Duffield | |
Up till now our approach to rendering things like file diffs, branch logs, and commit patches, has been to run a command on the command line, wait for it to complete, take its output as a string, and then write that string to the main view (or secondary view e.g. when showing both staged and unstaged changes of a file). This has caused various issues. For once, if you are flicking through a list of files and an untracked file is particularly large, not only will this require lazygit to load that whole file into memory (or more accurately it's equally large diff), it also will slow down the UI thread while loading that file, and if the user continued down the list, the original command might eventually resolve and replace whatever the diff is for the newly selected file. Following what we've done in lazydocker, I've added a tasks package for when you need something done but you want it to cancel as soon as something newer comes up. Given this typically involves running a command to display to a view, I've added a viewBufferManagerMap struct to the Gui struct which allows you to define these tasks on a per-view basis. viewBufferManagers can run files and directly write the output to their view, meaning we no longer need to use so much memory. In the tasks package there is a helper method called NewCmdTask which takes a command, an initial amount of lines to read, and then runs that command, reads that number of lines, and allows for a readLines channel to tell it to read more lines. We read more lines when we scroll or resize the window. There is an adapter for the tasks package in a file called tasks_adapter which wraps the functions from the tasks package in gui-specific stuff like clearing the main view before starting the next task that wants to write to the main view. I've removed some small features as part of this work, namely the little headers that were at the top of the main view for some situations. For example, we no longer show the upstream of a selected branch. I want to re-introduce this in the future, but I didn't want to make this tasks system too complicated, and in order to facilitate a header section in the main view we'd need to have a task that gets the upstream for the current branch, writes it to the header, then tells another task to write the branch log to the main view, but without clearing inbetween. So it would get messy. I'm thinking instead of having a separate 'header' view atop the main view to render that kind of thing (which can happen in another PR) I've also simplified the 'git show' to just call 'git show' and not do anything fancy when it comes to merge commits. I considered using this tasks approach whenever we write to a view. The only thing is that the renderString method currently resets the origin of a view and I don't want to lose that. So I've left some in there that I consider harmless, but we should probably be just using tasks now for all rendering, even if it's just strings we can instantly make. | |||
2020-01-12 | lazyload commits | Jesse Duffield | |
2020-01-09 | add reflog reset optionsv0.13 | Jesse Duffield | |
2020-01-09 | add checkout reflog commit keybinding | Jesse Duffield | |
2020-01-09 | add reflog tab in commits panel | Jesse Duffield | |
2020-01-08 | switch to 'i' for toggling diff commitsv0.12.3 | Jesse Duffield | |
2020-01-08 | refresh side panels when resetting to upstreamv0.12.1 | Jesse Duffield | |
2020-01-08 | escape editor path | Jamie Brynes | |
2020-01-08 | add git flow support | Jesse Duffield | |
2020-01-08 | don't watch deleted files | Jesse Duffield | |
2020-01-08 | minor fixup | Jesse Duffield | |
2020-01-08 | reduce to 50 | Jesse Duffield | |
2020-01-08 | improve file watching | Jesse Duffield | |
By default, macs have 256 open files allowed by a given process. This sucks when you end up with over 256 files modified in a repo because after you've watched all of them, lots of other calls to the command line will fail due to violating the limit. Given there's no easy platform agnostic way to see what you've got configured for how many files a process can have open, I'm going to arbitrarily set the max to 200 and when we hit the limit we start unwatching older files to make way for new ones. WIP | |||
2020-01-07 | added a seperate keybinding option for checking out commits | David Chen | |
2020-01-07 | fix display of menu option keybindings | David Chen | |
2020-01-07 | cleanup | David Chen | |
2020-01-07 | customizable keybinding for toggleDiffCommit | David Chen | |
2020-01-07 | Merge branch 'master' into custom-keybindings | David Chen | |
2020-01-07 | fixed keybinding display in merge_panel.go | David Chen | |
2020-01-07 | allow commits to be checked out | Jesse Duffield | |
2020-01-07 | allow hard resetting to upstream branch | Jesse Duffield | |
2020-01-07 | Use ASCII on Windows with east asian locale | Yasuhiro Matsumoto | |
2020-01-07 | updated keybinding config docs | David Chen | |
2020-01-07 | Merge branch 'master' into custom-keybindings | David Chen | |
2020-01-06 | if statements to map | David Chen | |
2020-01-06 | PickBothHunks -> pickBothHunks | David Chen | |