summaryrefslogtreecommitdiffstats
path: root/pkg/gui/commit_files_panel.go
AgeCommit message (Collapse)Author
2020-08-23better handling of there being no commit filesJesse Duffield
2020-08-23allow explicitly managing focusJesse Duffield
2020-08-23use context to return to the correct viewJesse Duffield
2020-08-23fix up patch managerJesse Duffield
2020-08-23minor refactorJesse Duffield
2020-08-23cleanup now that we're always using the same diff commandJesse Duffield
2020-08-23support creating patches from files in diff modeJesse Duffield
2020-08-23stop loading all the diffs at once now that we load them as we goJesse Duffield
2020-08-23faster patch managerJesse Duffield
2020-08-23support drilling down into the files of a diffJesse Duffield
2020-08-23when toggling files reset patch manager if patch ends up emptyJesse Duffield
2020-08-23remove sdumpJesse Duffield
2020-08-23refactorJesse Duffield
2020-08-23generalise patch building stuffJesse Duffield
2020-08-23rename Sha to parent now that we're also considering stash entriesJesse Duffield
2020-08-23slightly betterJesse Duffield
2020-08-23commit files kind of generalisedJesse Duffield
2020-08-23allowing commit files to be viewed in reflog as wellJesse Duffield
2020-08-23rename to SelectedLineIdxJesse Duffield
2020-08-23standardise diffmodeJesse Duffield
2020-08-23more standardisationJesse Duffield
2020-08-23some more thingsJesse Duffield
2020-08-23good progressJesse Duffield
2020-08-23centralise setting of main views contextJesse Duffield
2020-08-23WIPJesse Duffield
2020-08-23WIPJesse Duffield
2020-08-23lots more stuffJesse Duffield
2020-08-23WIPJesse Duffield
2020-08-23centralise some list view codeJesse Duffield
2020-08-15more removing of g and vJesse Duffield
2020-08-15renameJesse Duffield
2020-08-15clean up interface for popup panelsJesse Duffield
2020-07-21allow editing commit filesv0.20.11Jesse Duffield
2020-03-29add new diff modeJesse Duffield
WIP WIP WIP WIP WIP WIP WIP
2020-03-28fix up some things with the patch handling stuffJesse Duffield
2020-03-28better error handlingJesse Duffield
2020-03-28smart refreshing filesJesse Duffield
2020-03-28more centralised handling of refreshingJesse Duffield
2020-03-09big golangci-lint cleanupJesse Duffield
2020-03-04supporing custom pagers step 1Jesse Duffield
2020-02-25refactor the way we render listsJesse Duffield
2020-02-24support searching in side panelsJesse Duffield
For now we're just doing side panels, because it will take more work to support this in the various main panel contexts
2020-01-31fix segfault on line by line panelJesse Duffield
The state object is sometimes undefined in the onclick method of the line by line panel. Because we set it to nil in a bunch of places, I've decided to just change the main context to 'normal' before setting it to nil anywhere. That way the keybindings for the line by line panel won't get executed and we won't get a segfault.
2020-01-12allow fast flicking through any list panelJesse Duffield
Up till now our approach to rendering things like file diffs, branch logs, and commit patches, has been to run a command on the command line, wait for it to complete, take its output as a string, and then write that string to the main view (or secondary view e.g. when showing both staged and unstaged changes of a file). This has caused various issues. For once, if you are flicking through a list of files and an untracked file is particularly large, not only will this require lazygit to load that whole file into memory (or more accurately it's equally large diff), it also will slow down the UI thread while loading that file, and if the user continued down the list, the original command might eventually resolve and replace whatever the diff is for the newly selected file. Following what we've done in lazydocker, I've added a tasks package for when you need something done but you want it to cancel as soon as something newer comes up. Given this typically involves running a command to display to a view, I've added a viewBufferManagerMap struct to the Gui struct which allows you to define these tasks on a per-view basis. viewBufferManagers can run files and directly write the output to their view, meaning we no longer need to use so much memory. In the tasks package there is a helper method called NewCmdTask which takes a command, an initial amount of lines to read, and then runs that command, reads that number of lines, and allows for a readLines channel to tell it to read more lines. We read more lines when we scroll or resize the window. There is an adapter for the tasks package in a file called tasks_adapter which wraps the functions from the tasks package in gui-specific stuff like clearing the main view before starting the next task that wants to write to the main view. I've removed some small features as part of this work, namely the little headers that were at the top of the main view for some situations. For example, we no longer show the upstream of a selected branch. I want to re-introduce this in the future, but I didn't want to make this tasks system too complicated, and in order to facilitate a header section in the main view we'd need to have a task that gets the upstream for the current branch, writes it to the header, then tells another task to write the branch log to the main view, but without clearing inbetween. So it would get messy. I'm thinking instead of having a separate 'header' view atop the main view to render that kind of thing (which can happen in another PR) I've also simplified the 'git show' to just call 'git show' and not do anything fancy when it comes to merge commits. I considered using this tasks approach whenever we write to a view. The only thing is that the renderString method currently resets the origin of a view and I don't want to lose that. So I've left some in there that I consider harmless, but we should probably be just using tasks now for all rendering, even if it's just strings we can instantly make.
2019-11-21support viewing a remote branchJesse Duffield
2019-11-21extract out some logic for list viewsJesse Duffield
2019-11-21add contexts to viewsJesse Duffield
2019-11-10simplify how the context system worksJesse Duffield
2019-11-10add mouse supportJesse Duffield
2019-11-10reset patch builder when we've escaped from the building phase and nothing ↵Jesse Duffield
has been added