summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2020-02-15refactor commit reset menuJesse Duffield
2020-02-15continue refactor of menu panelJesse Duffield
2020-02-15begin refactor of menu panelJesse Duffield
2020-02-13get whole commit SHA from rebase commitsv0.14.3Jesse Duffield
2020-02-10refresh current branch graph when side panels refreshJesse Duffield
2020-02-09Fixed testsGlenn Vriesman
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
2020-02-09Use 8 instead of 7 digit long shaGlenn Vriesman
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
2020-02-09Increase internal sha sizeGlenn Vriesman
This does not change the sha size that is displayed to the user Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
2020-02-09ignore carriage returnsJesse Duffield
2020-02-06Moved function to git.goGlenn Vriesman
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
2020-02-06Added feature to ignore tracked filesGlenn Vriesman
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
2020-02-06fix goreleaserv0.14.2Jesse Duffield
2020-02-06doc: mention config file location for MacOSMarco Molteni
2020-02-04Added more keybindsv0.14.1Glenn Vriesman
* Commit with editor * Commit without hook Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
2020-02-04Added commit keybinding to staging viewsGlenn Vriesman
2020-02-04Check cached when showing new file diffsGlenn Vriesman
Signed-off-by: Glenn Vriesman <glenn.vriesman@gmail.com>
2020-02-03correctly compare new main height to previousJesse Duffield
2020-02-02verify that VISUAL,EDITOR,LGCC envvars are set for non-interactive commandsv0.14Chris Taylor
2020-02-02add a helper to search a list for a patternChris Taylor
2020-02-02perpetuate this style of dependency injectionChris Taylor
2020-02-02make amend more non-interactiveChris Taylor
2020-02-02bump gocuiJesse Duffield
2020-02-02more ticker improvementsJesse Duffield
2020-02-01bump vendor directoryJesse Duffield
2020-02-01explicitly tell gocui when to start animating the loaderJesse Duffield
2020-02-01only rerender app status when we need toJesse Duffield
2020-01-31close more things when switching repos or to a subprocessJesse Duffield
2020-01-31Update example config for Colemak Keyboard Layout usersDavid Chen
I realized that the current example config in `Config.md` for a Colemak keyboard layout user will cause key conflicts in certain panels. This change addresses that issue.
2020-01-31fix keybinding issues with freebsd/openbsdJesse Duffield
2020-01-31fix segfault on line by line panelJesse Duffield
The state object is sometimes undefined in the onclick method of the line by line panel. Because we set it to nil in a bunch of places, I've decided to just change the main context to 'normal' before setting it to nil anywhere. That way the keybindings for the line by line panel won't get executed and we won't get a segfault.
2020-01-29handle files that were deleted downstream but modified upstreamJesse Duffield
2020-01-29split main view verticallyJesse Duffield
When staging lines (or doing anything that requires the main view to split into two) we want to split vertically if there's not much width available in the window. If there is enough width we will split horizontally. The aim here is to allow for sufficient room in the side panel. We might need to tweak this or make it configurable but I think it's set to a pretty reasonable default i.e. switching to split vertically when the window width falls under 220
2020-01-29safely unstage linesJesse Duffield
2020-01-29remove rollbarJesse Duffield
2020-01-29make use of branch config when pushing/pullingJesse Duffield
2020-01-28fix commentJesse Duffield
2020-01-28use reflog timestamps rather than commit timestamps to show commit recencyJesse Duffield
2020-01-16Merge pull request #597 from jamiebrynes7/bugfix/fix-crash-on-exitDawid Dziurla
Fix crash on exit
2020-01-16handle case where file watcher is disabledJamie Brynes
2020-01-12handle when fsnotify doesn't workJesse Duffield
2020-01-12Missed a spot with this new string task thingJesse Duffield
The issue here was that we were using a string task but expecting to be able to set the origin straight after to point at the conflict, but because it's async it was actually resetting the origin to 0 after a little bit. The proper solution here is maybe to add a flag to that thing asking whether you want to reset main's origin. But I'm too lazy to do that right now so instead I'm just using setViewContent. That will probably cause issues in the future.
2020-01-12use mutexes on escape codeJesse Duffield
2020-01-12reset origin when clicking on list itemJesse Duffield
2020-01-12bump gocuiJesse Duffield
2020-01-12use view line height to see if you should stop scrollingJesse Duffield
2020-01-12keep track of current view when pushingJesse Duffield
2020-01-12allow fast flicking through any list panelJesse Duffield
Up till now our approach to rendering things like file diffs, branch logs, and commit patches, has been to run a command on the command line, wait for it to complete, take its output as a string, and then write that string to the main view (or secondary view e.g. when showing both staged and unstaged changes of a file). This has caused various issues. For once, if you are flicking through a list of files and an untracked file is particularly large, not only will this require lazygit to load that whole file into memory (or more accurately it's equally large diff), it also will slow down the UI thread while loading that file, and if the user continued down the list, the original command might eventually resolve and replace whatever the diff is for the newly selected file. Following what we've done in lazydocker, I've added a tasks package for when you need something done but you want it to cancel as soon as something newer comes up. Given this typically involves running a command to display to a view, I've added a viewBufferManagerMap struct to the Gui struct which allows you to define these tasks on a per-view basis. viewBufferManagers can run files and directly write the output to their view, meaning we no longer need to use so much memory. In the tasks package there is a helper method called NewCmdTask which takes a command, an initial amount of lines to read, and then runs that command, reads that number of lines, and allows for a readLines channel to tell it to read more lines. We read more lines when we scroll or resize the window. There is an adapter for the tasks package in a file called tasks_adapter which wraps the functions from the tasks package in gui-specific stuff like clearing the main view before starting the next task that wants to write to the main view. I've removed some small features as part of this work, namely the little headers that were at the top of the main view for some situations. For example, we no longer show the upstream of a selected branch. I want to re-introduce this in the future, but I didn't want to make this tasks system too complicated, and in order to facilitate a header section in the main view we'd need to have a task that gets the upstream for the current branch, writes it to the header, then tells another task to write the branch log to the main view, but without clearing inbetween. So it would get messy. I'm thinking instead of having a separate 'header' view atop the main view to render that kind of thing (which can happen in another PR) I've also simplified the 'git show' to just call 'git show' and not do anything fancy when it comes to merge commits. I considered using this tasks approach whenever we write to a view. The only thing is that the renderString method currently resets the origin of a view and I don't want to lose that. So I've left some in there that I consider harmless, but we should probably be just using tasks now for all rendering, even if it's just strings we can instantly make.
2020-01-12lazyload commitsJesse Duffield
2020-01-09add reflog reset optionsv0.13Jesse Duffield
2020-01-09add checkout reflog commit keybindingJesse Duffield