diff options
author | Jesse Duffield <jessedduffield@gmail.com> | 2020-05-19 18:29:56 +1000 |
---|---|---|
committer | Jesse Duffield <jessedduffield@gmail.com> | 2020-05-19 18:44:53 +1000 |
commit | cf5cefb2d6bcfd0d403faca5875124eb9b0d7480 (patch) | |
tree | db67505182488590e152afee0d0f89d983ddaf57 /pkg | |
parent | 36ac764133d3837a22619db922bd8d54f4b0938e (diff) |
allow user to scroll themselves inside merge panelv0.20.4
Diffstat (limited to 'pkg')
-rw-r--r-- | pkg/gui/global_handlers.go | 8 | ||||
-rw-r--r-- | pkg/gui/gui.go | 4 | ||||
-rw-r--r-- | pkg/gui/merge_panel.go | 34 |
3 files changed, 46 insertions, 0 deletions
diff --git a/pkg/gui/global_handlers.go b/pkg/gui/global_handlers.go index 5df00d56f..d1947eff1 100644 --- a/pkg/gui/global_handlers.go +++ b/pkg/gui/global_handlers.go @@ -65,10 +65,18 @@ func (gui *Gui) scrollDownView(viewName string) error { } func (gui *Gui) scrollUpMain(g *gocui.Gui, v *gocui.View) error { + if gui.canScrollMergePanel() { + gui.State.Panels.Merging.UserScrolling = true + } + return gui.scrollUpView("main") } func (gui *Gui) scrollDownMain(g *gocui.Gui, v *gocui.View) error { + if gui.canScrollMergePanel() { + gui.State.Panels.Merging.UserScrolling = true + } + return gui.scrollDownView("main") } diff --git a/pkg/gui/gui.go b/pkg/gui/gui.go index 2fc029b64..735a5465e 100644 --- a/pkg/gui/gui.go +++ b/pkg/gui/gui.go @@ -112,6 +112,10 @@ type mergingPanelState struct { ConflictTop bool Conflicts []commands.Conflict EditHistory *stack.Stack + + // UserScrolling tells us if the user has started scrolling through the file themselves + // in which case we won't auto-scroll to a conflict. + UserScrolling bool } type filePanelState struct { diff --git a/pkg/gui/merge_panel.go b/pkg/gui/merge_panel.go index a2346db6e..a70d7fbbb 100644 --- a/pkg/gui/merge_panel.go +++ b/pkg/gui/merge_panel.go @@ -69,17 +69,24 @@ func (gui *Gui) coloredConflictFile(content string, conflicts []commands.Conflic return outputBuffer.String(), nil } +func (gui *Gui) takeOverScrolling() { + gui.State.Panels.Merging.UserScrolling = false +} + func (gui *Gui) handleSelectTop(g *gocui.Gui, v *gocui.View) error { + gui.takeOverScrolling() gui.State.Panels.Merging.ConflictTop = true return gui.refreshMergePanel() } func (gui *Gui) handleSelectBottom(g *gocui.Gui, v *gocui.View) error { + gui.takeOverScrolling() gui.State.Panels.Merging.ConflictTop = false return gui.refreshMergePanel() } func (gui *Gui) handleSelectNextConflict(g *gocui.Gui, v *gocui.View) error { + gui.takeOverScrolling() if gui.State.Panels.Merging.ConflictIndex >= len(gui.State.Panels.Merging.Conflicts)-1 { return nil } @@ -88,6 +95,7 @@ func (gui *Gui) handleSelectNextConflict(g *gocui.Gui, v *gocui.View) error { } func (gui *Gui) handleSelectPrevConflict(g *gocui.Gui, v *gocui.View) error { + gui.takeOverScrolling() if gui.State.Panels.Merging.ConflictIndex <= 0 { return nil } @@ -160,6 +168,8 @@ func (gui *Gui) handlePopFileSnapshot(g *gocui.Gui, v *gocui.View) error { } func (gui *Gui) handlePickHunk(g *gocui.Gui, v *gocui.View) error { + gui.takeOverScrolling() + conflict := gui.State.Panels.Merging.Conflicts[gui.State.Panels.Merging.ConflictIndex] if err := gui.pushFileSnapshot(g); err != nil { return err @@ -184,6 +194,8 @@ func (gui *Gui) handlePickHunk(g *gocui.Gui, v *gocui.View) error { } func (gui *Gui) handlePickBothHunks(g *gocui.Gui, v *gocui.View) error { + gui.takeOverScrolling() + conflict := gui.State.Panels.Merging.Conflicts[gui.State.Panels.Merging.ConflictIndex] if err := gui.pushFileSnapshot(g); err != nil { return err @@ -256,6 +268,10 @@ func (gui *Gui) catSelectedFile(g *gocui.Gui) (string, error) { } func (gui *Gui) scrollToConflict(g *gocui.Gui) error { + if gui.State.Panels.Merging.UserScrolling { + return nil + } + panelState := gui.State.Panels.Merging if len(panelState.Conflicts) == 0 { return nil @@ -283,6 +299,8 @@ func (gui *Gui) renderMergeOptions() error { } func (gui *Gui) handleEscapeMerge(g *gocui.Gui, v *gocui.View) error { + gui.takeOverScrolling() + gui.State.Panels.Merging.EditHistory = stack.New() if err := gui.refreshSidePanels(refreshOptions{scope: []int{FILES}}); err != nil { return err @@ -316,7 +334,23 @@ func (gui *Gui) handleCompleteMerge() error { // promptToContinue asks the user if they want to continue the rebase/merge that's in progress func (gui *Gui) promptToContinue() error { + gui.takeOverScrolling() + return gui.createConfirmationPanel(gui.g, gui.getFilesView(), true, "continue", gui.Tr.SLocalize("ConflictsResolved"), func(g *gocui.Gui, v *gocui.View) error { return gui.genericMergeCommand("continue") }, nil) } + +func (gui *Gui) canScrollMergePanel() bool { + currentViewName := gui.currentViewName() + if currentViewName != "main" { + return false + } + + file, err := gui.getSelectedFile() + if err != nil { + return false + } + + return file.HasInlineMergeConflicts +} |