add more suggestions

2 files changed, 111 insertions, 0 deletions

diff --git a/pkg/utils/slice.go b/pkg/utils/slice.go
index f536ea056..48acdbd2d 100644
--- a/pkg/utils/slice.go
+++ b/pkg/utils/slice.go
@@ -116,3 +116,31 @@ func StringArraysOverlap(strArrA []string, strArrB []string) bool {
 
 	return false
 }
+
+func Uniq(values []string) []string {
+	added := make(map[string]bool)
+	result := make([]string, 0, len(values))
+	for _, value := range values {
+		if added[value] {
+			continue
+		}
+		added[value] = true
+		result = append(result, value)
+	}
+	return result
+}
+
+func Limit(values []string, limit int) []string {
+	if len(values) > limit {
+		return values[:limit]
+	}
+	return values
+}
+
+func Reverse(values []string) []string {
+	result := make([]string, len(values))
+	for i, val := range values {
+		result[len(values)-i-1] = val
+	}
+	return result
+}
diff --git a/pkg/utils/slice_test.go b/pkg/utils/slice_test.go
index 491968cb4..3636f44cb 100644
--- a/pkg/utils/slice_test.go
+++ b/pkg/utils/slice_test.go
@@ -165,3 +165,86 @@ func TestEscapeSpecialChars(t *testing.T) {
 		})
 	}
 }
+
+func TestUniq(t *testing.T) {
+	for _, test := range []struct {
+		values []string
+		want   []string
+	}{
+		{
+			values: []string{"a", "b", "c"},
+			want:   []string{"a", "b", "c"},
+		},
+		{
+			values: []string{"a", "b", "a", "b", "c"},
+			want:   []string{"a", "b", "c"},
+		},
+	} {
+		if got := Uniq(test.values); !assert.EqualValues(t, got, test.want) {
+			t.Errorf("Uniq(%v) = %v; want %v", test.values, got, test.want)
+		}
+	}
+}
+
+func TestLimit(t *testing.T) {
+	for _, test := range []struct {
+		values []string
+		limit  int
+		want   []string
+	}{
+		{
+			values: []string{"a", "b", "c"},
+			limit:  3,
+			want:   []string{"a", "b", "c"},
+		},
+		{
+			values: []string{"a", "b", "c"},
+			limit:  4,
+			want:   []string{"a", "b", "c"},
+		},
+		{
+			values: []string{"a", "b", "c"},
+			limit:  2,
+			want:   []string{"a", "b"},
+		},
+		{
+			values: []string{"a", "b", "c"},
+			limit:  1,
+			want:   []string{"a"},
+		},
+		{
+			values: []string{"a", "b", "c"},
+			limit:  0,
+			want:   []string{},
+		},
+		{
+			values: []string{},
+			limit:  0,
+			want:   []string{},
+		},
+	} {
+		if got := Limit(test.values, test.limit); !assert.EqualValues(t, got, test.want) {
+			t.Errorf("Limit(%v, %d) = %v; want %v", test.values, test.limit, got, test.want)
+		}
+	}
+}
+
+func TestReverse(t *testing.T) {
+	for _, test := range []struct {
+		values []string
+		want   []string
+	}{
+		{
+			values: []string{"a", "b", "c"},
+			want:   []string{"c", "b", "a"},
+		},
+		{
+			values: []string{},
+			want:   []string{},
+		},
+	} {
+		if got := Reverse(test.values); !assert.EqualValues(t, got, test.want) {
+			t.Errorf("Reverse(%v) = %v; want %v", test.values, got, test.want)
+		}
+	}
+}