diff options
author | Dawid Dziurla <dawidd0811@gmail.com> | 2018-09-05 13:01:21 +0200 |
---|---|---|
committer | Dawid Dziurla <dawidd0811@gmail.com> | 2018-09-05 13:16:40 +0200 |
commit | 906f8e252e43c1dbd2303fb90de660a2181e5f32 (patch) | |
tree | 25941fd431e59485485d0f6a8eef76daccf5f6db /pkg/gui | |
parent | 557009e660e3203dce62624599c173e25f086465 (diff) |
include global keybindings in menu
Diffstat (limited to 'pkg/gui')
-rw-r--r-- | pkg/gui/gui.go | 3 | ||||
-rw-r--r-- | pkg/gui/keybindings.go | 3 | ||||
-rw-r--r-- | pkg/gui/menu_panel.go | 15 |
3 files changed, 15 insertions, 6 deletions
diff --git a/pkg/gui/gui.go b/pkg/gui/gui.go index c9beb36eb..5642e0901 100644 --- a/pkg/gui/gui.go +++ b/pkg/gui/gui.go @@ -350,9 +350,6 @@ func (gui *Gui) renderAppStatus(g *gocui.Gui) error { func (gui *Gui) renderGlobalOptions(g *gocui.Gui) error { return gui.renderOptionsMap(g, map[string]string{ - "R": gui.Tr.SLocalize("refresh"), - "p": gui.Tr.SLocalize("pull"), - "P": gui.Tr.SLocalize("push"), "PgUp/PgDn": gui.Tr.SLocalize("scroll"), "← → ↑ ↓": gui.Tr.SLocalize("navigate"), "esc/q": gui.Tr.SLocalize("close"), diff --git a/pkg/gui/keybindings.go b/pkg/gui/keybindings.go index 0ca82d3c6..9202d7a1d 100644 --- a/pkg/gui/keybindings.go +++ b/pkg/gui/keybindings.go @@ -56,16 +56,19 @@ func (gui *Gui) GetKeybindings() []Binding { Key: 'P', Modifier: gocui.ModNone, Handler: gui.pushFiles, + Description: gui.Tr.SLocalize("push"), }, { ViewName: "", Key: 'p', Modifier: gocui.ModNone, Handler: gui.pullFiles, + Description: gui.Tr.SLocalize("pull"), }, { ViewName: "", Key: 'R', Modifier: gocui.ModNone, Handler: gui.handleRefresh, + Description: gui.Tr.SLocalize("refresh"), }, { ViewName: "", Key: '?', diff --git a/pkg/gui/menu_panel.go b/pkg/gui/menu_panel.go index fa276e8c4..1bd02eeb2 100644 --- a/pkg/gui/menu_panel.go +++ b/pkg/gui/menu_panel.go @@ -10,6 +10,9 @@ import ( func (gui *Gui) handleMenuPress(g *gocui.Gui, v *gocui.View) error { lineNumber := gui.getItemPosition(v) + if gui.State.Keys[lineNumber].Key == nil { + return nil + } if len(gui.State.Keys) > lineNumber { err := gui.handleMenuClose(g, v) if err != nil { @@ -59,7 +62,7 @@ func (gui *Gui) GetKey(binding Binding) string { return key } -func (gui *Gui) getMaxKeyLength(bindings []Binding) int { +func (gui *Gui) GetMaxKeyLength(bindings []Binding) int { max := 0 for _, binding := range bindings { keyLength := len(gui.GetKey(binding)) @@ -74,11 +77,17 @@ func (gui *Gui) handleMenu(g *gocui.Gui, v *gocui.View) error { // clear keys slice, so we don't have ghost elements gui.State.Keys = gui.State.Keys[:0] content := "" + current := "" bindings := gui.GetKeybindings() - padWidth := gui.getMaxKeyLength(bindings) + padWidth := gui.GetMaxKeyLength(bindings) for _, binding := range bindings { - if key := gui.GetKey(binding); key != "" && binding.ViewName == v.Name() && binding.Description != "" { + if key := gui.GetKey(binding); key != "" && (binding.ViewName == v.Name() || binding.ViewName == "") && binding.Description != "" { + if binding.ViewName != current { + content += "\n" + gui.State.Keys = append(gui.State.Keys, Binding{}) + current = binding.ViewName + } content += fmt.Sprintf("%s %s\n", utils.WithPadding(key, padWidth), binding.Description) gui.State.Keys = append(gui.State.Keys, binding) } |