summaryrefslogtreecommitdiffstats
path: root/pkg/gui/merge_panel.go
diff options
context:
space:
mode:
authorJesse Duffield <jessedduffield@gmail.com>2019-02-16 21:30:29 +1100
committerJesse Duffield <jessedduffield@gmail.com>2019-02-16 21:30:29 +1100
commitcb372d469fd5d50fff919f49c2fd539dfb874ee8 (patch)
tree89505cabaff0a1951519cf9fa76cf910222cb990 /pkg/gui/merge_panel.go
parent88ba6efdd5fbac6eb2313f2472f83bde3203c936 (diff)
fix golangci errors
Diffstat (limited to 'pkg/gui/merge_panel.go')
-rw-r--r--pkg/gui/merge_panel.go19
1 files changed, 10 insertions, 9 deletions
diff --git a/pkg/gui/merge_panel.go b/pkg/gui/merge_panel.go
index fccfb3a59..efb6c5544 100644
--- a/pkg/gui/merge_panel.go
+++ b/pkg/gui/merge_panel.go
@@ -171,8 +171,7 @@ func (gui *Gui) handlePickHunk(g *gocui.Gui, v *gocui.View) error {
return err
}
}
- gui.refreshMergePanel()
- return nil
+ return gui.refreshMergePanel()
}
func (gui *Gui) handlePickBothHunks(g *gocui.Gui, v *gocui.View) error {
@@ -194,7 +193,6 @@ func (gui *Gui) refreshMergePanel() error {
if cat == "" {
return nil
}
- gui.Log.Info(cat)
panelState.Conflicts, err = gui.findConflicts(cat)
if err != nil {
return err
@@ -232,13 +230,10 @@ func (gui *Gui) scrollToConflict(g *gocui.Gui) error {
}
mergingView := gui.getMainView()
conflict := panelState.Conflicts[panelState.ConflictIndex]
- gui.Log.Info(utils.AsJson(conflict))
ox, _ := mergingView.Origin()
_, height := mergingView.Size()
conflictMiddle := (conflict.End + conflict.Start) / 2
newOriginY := int(math.Max(0, float64(conflictMiddle-(height/2))))
- gui.Log.Info(utils.AsJson("origin Y"))
- gui.Log.Info(utils.AsJson(newOriginY))
gui.g.Update(func(g *gocui.Gui) error {
return mergingView.SetOrigin(ox, newOriginY)
})
@@ -257,7 +252,9 @@ func (gui *Gui) renderMergeOptions() error {
func (gui *Gui) handleEscapeMerge(g *gocui.Gui, v *gocui.View) error {
gui.State.Panels.Merging.EditHistory = stack.New()
- gui.refreshFiles()
+ if err := gui.refreshFiles(); err != nil {
+ return err
+ }
// it's possible this method won't be called from the merging view so we need to
// ensure we only 'return' focus if we already have it
if gui.g.CurrentView() == gui.getMainView() {
@@ -268,8 +265,12 @@ func (gui *Gui) handleEscapeMerge(g *gocui.Gui, v *gocui.View) error {
func (gui *Gui) handleCompleteMerge() error {
filesView := gui.getFilesView()
- gui.stageSelectedFile(gui.g)
- gui.refreshFiles()
+ if err := gui.stageSelectedFile(gui.g); err != nil {
+ return err
+ }
+ if err := gui.refreshFiles(); err != nil {
+ return err
+ }
// if we got conflicts after unstashing, we don't want to call any git
// commands to continue rebasing/merging here
if gui.State.WorkingTreeState == "normal" {