Return whether the context has a parent or not along with that parent

There has got to be a better way around this but if we're returning a Context
from a function (Context is an interface, not a concrete type), even if we
return nil, on the calling end it won't be equal to nil because an interface
value is a tuple of the type and the value meaning it's never itself nil,
unless both values in the tuple are nil.

So we're explicitly returning whether or not the underlying concrete type is nil.

1 files changed, 5 insertions, 3 deletions

diff --git a/pkg/gui/context.go b/pkg/gui/context.go
index b198cb7e9..937106953 100644
--- a/pkg/gui/context.go
+++ b/pkg/gui/context.go
@@ -46,7 +46,9 @@ type Context interface {
 	SetWindowName(string)
 	GetKey() string
 	SetParentContext(Context)
-	GetParentContext() Context
+
+	// we return a bool here to tell us whether or not the returned value just wraps a nil
+	GetParentContext() (Context, bool)
 	GetOptionsMap() map[string]string
 }
 
@@ -80,8 +82,8 @@ func (c BasicContext) SetParentContext(Context) {
 	panic("can't set parent context on basic context")
 }
 
-func (c BasicContext) GetParentContext() Context {
-	panic("can't get parent context on basic context")
+func (c BasicContext) GetParentContext() (Context, bool) {
+	return nil, false
 }
 
 func (c BasicContext) HandleRender() error {