From 4ef9baf5bd24b6a105f78eba1147dad9ffabd82a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Erik=20Pedersen?= Date: Tue, 24 Jan 2023 20:57:15 +0100 Subject: Only invoke a given cached partial once MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Note that this is backed by a LRU cache (which we soon shall see more usage of), so if you're a heavy user of cached partials it may be evicted and refreshed if needed. But in most cases every partial is only invoked once. This commit also adds a timeout (the global `timeout` config option) to make infinite recursion in partials easier to reason about. ``` name old time/op new time/op delta IncludeCached-10 8.92ms ± 0% 8.48ms ± 1% -4.87% (p=0.016 n=4+5) name old alloc/op new alloc/op delta IncludeCached-10 6.65MB ± 0% 5.17MB ± 0% -22.32% (p=0.002 n=6+6) name old allocs/op new allocs/op delta IncludeCached-10 117k ± 0% 71k ± 0% -39.44% (p=0.002 n=6+6) ``` Closes #4086 Updates #9588 --- hugolib/page_test.go | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) (limited to 'hugolib/page_test.go') diff --git a/hugolib/page_test.go b/hugolib/page_test.go index 1d9e3e348..939d06d41 100644 --- a/hugolib/page_test.go +++ b/hugolib/page_test.go @@ -24,6 +24,7 @@ import ( "github.com/bep/clock" "github.com/gohugoio/hugo/htesting" + "github.com/gohugoio/hugo/identity" "github.com/gohugoio/hugo/markup/asciidocext" "github.com/gohugoio/hugo/markup/rst" "github.com/gohugoio/hugo/tpl" @@ -2001,3 +2002,37 @@ Page1: {{ $p1.Path }} b.AssertFileContent("public/index.html", "Lang: no", filepath.FromSlash("Page1: a/B/C/Page1.md")) } + +func TestPageHashString(t *testing.T) { + files := ` +-- config.toml -- +baseURL = "https://example.org" +[languages] +[languages.en] +weight = 1 +title = "English" +[languages.no] +weight = 2 +title = "Norsk" +-- content/p1.md -- +--- +title: "p1" +--- +-- content/p2.md -- +--- +title: "p2" +--- +` + + b := NewIntegrationTestBuilder(IntegrationTestConfig{ + T: t, + TxtarString: files, + }).Build() + + p1 := b.H.Sites[0].RegularPages()[0] + p2 := b.H.Sites[0].RegularPages()[1] + sites := p1.Sites() + + b.Assert(identity.HashString(p1), qt.Not(qt.Equals), identity.HashString(p2)) + b.Assert(identity.HashString(sites[0]), qt.Not(qt.Equals), identity.HashString(sites[1])) +} -- cgit v1.2.3