summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--commands/convert.go85
-rw-r--r--commands/hugo.go4
-rw-r--r--commands/import_jekyll.go4
-rw-r--r--go.mod3
-rw-r--r--go.sum5
-rw-r--r--hugolib/site.go14
-rw-r--r--parser/frontmatter.go232
-rw-r--r--parser/frontmatter_test.go266
-rw-r--r--parser/metadecoders/decoder.go146
-rw-r--r--parser/metadecoders/decoder_test.go207
-rw-r--r--parser/metadecoders/format.go66
-rw-r--r--parser/metadecoders/format_test.go57
-rw-r--r--parser/metadecoders/json.go31
-rw-r--r--parser/metadecoders/yaml.go84
-rw-r--r--parser/page.go9
-rw-r--r--parser/page_test.go129
-rw-r--r--parser/pageparser/item.go2
-rw-r--r--parser/pageparser/pagelexer.go34
-rw-r--r--parser/pageparser/pageparser.go10
-rw-r--r--parser/pageparser/pageparser_intro_test.go2
-rw-r--r--tpl/transform/remarshal.go25
-rw-r--r--tpl/transform/remarshal_test.go15
22 files changed, 623 insertions, 807 deletions
diff --git a/commands/convert.go b/commands/convert.go
index dc6b8fe15..29714301f 100644
--- a/commands/convert.go
+++ b/commands/convert.go
@@ -14,8 +14,19 @@
package commands
import (
+ "bytes"
+ "fmt"
+ "strings"
"time"
+ "github.com/gohugoio/hugo/hugofs"
+
+ "github.com/gohugoio/hugo/helpers"
+
+ "github.com/gohugoio/hugo/parser"
+ "github.com/gohugoio/hugo/parser/metadecoders"
+ "github.com/gohugoio/hugo/parser/pageparser"
+
src "github.com/gohugoio/hugo/source"
"github.com/pkg/errors"
@@ -23,7 +34,6 @@ import (
"path/filepath"
- "github.com/gohugoio/hugo/parser"
"github.com/spf13/cast"
"github.com/spf13/cobra"
)
@@ -60,7 +70,7 @@ See convert's subcommands toJSON, toTOML and toYAML for more information.`,
Long: `toJSON converts all front matter in the content directory
to use JSON for the front matter.`,
RunE: func(cmd *cobra.Command, args []string) error {
- return cc.convertContents(rune([]byte(parser.JSONLead)[0]))
+ return cc.convertContents(metadecoders.JSON)
},
},
&cobra.Command{
@@ -69,7 +79,7 @@ to use JSON for the front matter.`,
Long: `toTOML converts all front matter in the content directory
to use TOML for the front matter.`,
RunE: func(cmd *cobra.Command, args []string) error {
- return cc.convertContents(rune([]byte(parser.TOMLLead)[0]))
+ return cc.convertContents(metadecoders.TOML)
},
},
&cobra.Command{
@@ -78,7 +88,7 @@ to use TOML for the front matter.`,
Long: `toYAML converts all front matter in the content directory
to use YAML for the front matter.`,
RunE: func(cmd *cobra.Command, args []string) error {
- return cc.convertContents(rune([]byte(parser.YAMLLead)[0]))
+ return cc.convertContents(metadecoders.YAML)
},
},
)
@@ -91,7 +101,7 @@ to use YAML for the front matter.`,
return cc
}
-func (cc *convertCmd) convertContents(mark rune) error {
+func (cc *convertCmd) convertContents(format metadecoders.Format) error {
if cc.outputDir == "" && !cc.unsafe {
return newUserError("Unsafe operation not allowed, use --unsafe or set a different output path")
}
@@ -114,17 +124,17 @@ func (cc *convertCmd) convertContents(mark rune) error {
site.Log.FEEDBACK.Println("processing", len(site.AllPages), "content files")
for _, p := range site.AllPages {
- if err := cc.convertAndSavePage(p, site, mark); err != nil {
+ if err := cc.convertAndSavePage(p, site, format); err != nil {
return err
}
}
return nil
}
-func (cc *convertCmd) convertAndSavePage(p *hugolib.Page, site *hugolib.Site, mark rune) error {
+func (cc *convertCmd) convertAndSavePage(p *hugolib.Page, site *hugolib.Site, targetFormat metadecoders.Format) error {
// The resources are not in .Site.AllPages.
for _, r := range p.Resources.ByType("page") {
- if err := cc.convertAndSavePage(r.(*hugolib.Page), site, mark); err != nil {
+ if err := cc.convertAndSavePage(r.(*hugolib.Page), site, targetFormat); err != nil {
return err
}
}
@@ -134,37 +144,56 @@ func (cc *convertCmd) convertAndSavePage(p *hugolib.Page, site *hugolib.Site, ma
return nil
}
+ errMsg := fmt.Errorf("Error processing file %q", p.Path())
+
site.Log.INFO.Println("Attempting to convert", p.LogicalName())
- newPage, err := site.NewPage(p.LogicalName())
- if err != nil {
- return err
- }
f, _ := p.File.(src.ReadableFile)
file, err := f.Open()
if err != nil {
- site.Log.ERROR.Println("Error reading file:", p.Path())
+ site.Log.ERROR.Println(errMsg)
file.Close()
return nil
}
- psr, err := parser.ReadFrom(file)
+ psr, err := pageparser.Parse(file)
if err != nil {
- site.Log.ERROR.Println("Error processing file:", p.Path())
+ site.Log.ERROR.Println(errMsg)
file.Close()
return err
}
file.Close()
- metadata, err := psr.Metadata()
+ var sourceFormat, sourceContent []byte
+ var fromFormat metadecoders.Format
+
+ iter := psr.Iterator()
+
+ walkFn := func(item pageparser.Item) bool {
+ if sourceFormat != nil {
+ // The rest is content.
+ sourceContent = psr.Input()[item.Pos:]
+ // Done
+ return false
+ } else if item.IsFrontMatter() {
+ fromFormat = metadecoders.FormatFromFrontMatterType(item.Type)
+ sourceFormat = item.Val
+ }
+ return true
+
+ }
+
+ iter.PeekWalk(walkFn)
+
+ metadata, err := metadecoders.UnmarshalToMap(sourceFormat, fromFormat)
if err != nil {
- site.Log.ERROR.Println("Error processing file:", p.Path())
+ site.Log.ERROR.Println(errMsg)
return err
}
// better handling of dates in formats that don't have support for them
- if mark == parser.FormatToLeadRune("json") || mark == parser.FormatToLeadRune("yaml") || mark == parser.FormatToLeadRune("toml") {
+ if fromFormat == metadecoders.JSON || fromFormat == metadecoders.YAML || fromFormat == metadecoders.TOML {
newMetadata := cast.ToStringMap(metadata)
for k, v := range newMetadata {
switch vv := v.(type) {
@@ -175,18 +204,26 @@ func (cc *convertCmd) convertAndSavePage(p *hugolib.Page, site *hugolib.Site, ma
metadata = newMetadata
}
- newPage.SetSourceContent(psr.Content())
- if err = newPage.SetSourceMetaData(metadata, mark); err != nil {
- site.Log.ERROR.Printf("Failed to set source metadata for file %q: %s. For more info see For more info see https://github.com/gohugoio/hugo/issues/2458", newPage.FullFilePath(), err)
- return nil
+ var newContent bytes.Buffer
+ err = parser.InterfaceToFrontMatter2(metadata, targetFormat, &newContent)
+ if err != nil {
+ site.Log.ERROR.Println(errMsg)
+ return err
}
+ newContent.Write(sourceContent)
+
newFilename := p.Filename()
+
if cc.outputDir != "" {
- newFilename = filepath.Join(cc.outputDir, p.Dir(), newPage.LogicalName())
+ contentDir := strings.TrimSuffix(newFilename, p.Path())
+ contentDir = filepath.Base(contentDir)
+
+ newFilename = filepath.Join(cc.outputDir, contentDir, p.Path())
}
- if err = newPage.SaveSourceAs(newFilename); err != nil {
+ fs := hugofs.Os
+ if err := helpers.WriteToDisk(newFilename, &newContent, fs); err != nil {
return errors.Wrapf(err, "Failed to save file %q:", newFilename)
}
diff --git a/commands/hugo.go b/commands/hugo.go
index deaa1f7ff..2204ae9f3 100644
--- a/commands/hugo.go
+++ b/commands/hugo.go
@@ -42,7 +42,7 @@ import (
"github.com/gohugoio/hugo/config"
- "github.com/gohugoio/hugo/parser"
+ "github.com/gohugoio/hugo/parser/metadecoders"
flag "github.com/spf13/pflag"
"github.com/fsnotify/fsnotify"
@@ -1017,7 +1017,7 @@ func (c *commandeer) isThemeVsHugoVersionMismatch(fs afero.Fs) (dir string, mism
b, err := afero.ReadFile(fs, path)
- tomlMeta, err := parser.HandleTOMLMetaData(b)
+ tomlMeta, err := metadecoders.UnmarshalToMap(b, metadecoders.TOML)
if err != nil {
continue
diff --git a/commands/import_jekyll.go b/commands/import_jekyll.go
index 6d88a7fd8..2a86840d6 100644
--- a/commands/import_jekyll.go
+++ b/commands/import_jekyll.go
@@ -25,6 +25,8 @@ import (
"strings"
"time"
+ "github.com/gohugoio/hugo/parser/metadecoders"
+
"github.com/gohugoio/hugo/helpers"
"github.com/gohugoio/hugo/hugofs"
"github.com/gohugoio/hugo/hugolib"
@@ -253,7 +255,7 @@ func (i *importCmd) loadJekyllConfig(fs afero.Fs, jekyllRoot string) map[string]
return nil
}
- c, err := parser.HandleYAMLMetaData(b)
+ c, err := metadecoders.UnmarshalToMap(b, metadecoders.YAML)
if err != nil {
return nil
diff --git a/go.mod b/go.mod
index aa73284e9..b93100976 100644
--- a/go.mod
+++ b/go.mod
@@ -51,7 +51,7 @@ require (
github.com/spf13/nitro v0.0.0-20131003134307-24d7ef30a12d
github.com/spf13/pflag v1.0.2
github.com/spf13/viper v1.2.0
- github.com/stretchr/testify v1.2.2
+ github.com/stretchr/testify v1.2.3-0.20181002232621-f2347ac6c9c9
github.com/tdewolff/minify v2.3.5+incompatible
github.com/tdewolff/parse v2.3.3+incompatible // indirect
github.com/tdewolff/test v0.0.0-20171106182207-265427085153 // indirect
@@ -63,6 +63,7 @@ require (
golang.org/x/sys v0.0.0-20180909124046-d0be0721c37e // indirect
golang.org/x/text v0.3.0
gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127 // indirect
+ gopkg.in/yaml.v1 v1.0.0-20140924161607-9f9df34309c0
gopkg.in/yaml.v2 v2.2.1
)
diff --git a/go.sum b/go.sum
index c41cacfb3..806cdc98a 100644
--- a/go.sum
+++ b/go.sum
@@ -65,6 +65,7 @@ github.com/magefile/mage v1.4.0 h1:RI7B1CgnPAuu2O9lWszwya61RLmfL0KCdo+QyyI/Bhk=
github.com/magefile/mage v1.4.0/go.mod h1:IUDi13rsHje59lecXokTfGX0QIzO45uVPlXnJYsXepA=
github.com/magiconair/properties v1.8.0 h1:LLgXmsheXeRoUOBOjtwPQCWIYqM/LU1ayDtDePerRcY=
github.com/magiconair/properties v1.8.0/go.mod h1:PppfXfuXeibc/6YijjN8zIbojt8czPbwD3XqdrwzmxQ=
+github.com/markbates/inflect v0.0.0-20171215194931-a12c3aec81a6 h1:LZhVjIISSbj8qLf2qDPP0D8z0uvOWAW5C85ly5mJW6c=
github.com/markbates/inflect v0.0.0-20171215194931-a12c3aec81a6/go.mod h1:oTeZL2KHA7CUX6X+fovmK9OvIOFuqu0TwdQrZjLTh88=
github.com/mattn/go-isatty v0.0.4 h1:bnP0vzxcAdeI1zdubAl5PjU6zsERjGZb7raWodagDYs=
github.com/mattn/go-isatty v0.0.4/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNxMWT7Zi4=
@@ -118,6 +119,8 @@ github.com/spf13/viper v1.2.0 h1:M4Rzxlu+RgU4pyBRKhKaVN1VeYOm8h2jgyXnAseDgCc=
github.com/spf13/viper v1.2.0/go.mod h1:P4AexN0a+C9tGAnUFNwDMYYZv3pjFuvmeiMyKRaNVlI=
github.com/stretchr/testify v1.2.2 h1:bSDNvY7ZPG5RlJ8otE/7V6gMiyenm9RtJ7IUVIAoJ1w=
github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
+github.com/stretchr/testify v1.2.3-0.20181002232621-f2347ac6c9c9 h1:kcVw9CGDqYBy0TTpIq2+BNR4W9poqiwEPBh/OYX5CaU=
+github.com/stretchr/testify v1.2.3-0.20181002232621-f2347ac6c9c9/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
github.com/tdewolff/minify v2.3.5+incompatible h1:oFxBKxTIY1F/1DEJhLeh/T507W56JqZtWVrawFcdadI=
github.com/tdewolff/minify v2.3.5+incompatible/go.mod h1:9Ov578KJUmAWpS6NeZwRZyT56Uf6o3Mcz9CEsg8USYs=
github.com/tdewolff/parse v2.3.3+incompatible h1:q6OSjvHtvBucLb34z24OH1xl5wGdw1mI9Vd38Qj9evs=
@@ -143,5 +146,7 @@ golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127 h1:qIbj1fsPNlZgppZ+VLlY7N33q108Sa+fhmuc+sWQYwY=
gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
+gopkg.in/yaml.v1 v1.0.0-20140924161607-9f9df34309c0 h1:POO/ycCATvegFmVuPpQzZFJ+pGZeX22Ufu6fibxDVjU=
+gopkg.in/yaml.v1 v1.0.0-20140924161607-9f9df34309c0/go.mod h1:WDnlLJ4WF5VGsH/HVa3CI79GS0ol3YnhVnKP89i0kNg=
gopkg.in/yaml.v2 v2.2.1 h1:mUhvW9EsL+naU5Q3cakzfE91YhliOondGd6ZrsDBHQE=
gopkg.in/yaml.v2 v2.2.1/go.mod h1:hI93XBmqTisBFMUTm0b8Fm+jr3Dg1NNxqwp+5A1VGuI=
diff --git a/hugolib/site.go b/hugolib/site.go
index 7f6ddce6c..cb980e8ab 100644
--- a/hugolib/site.go
+++ b/hugolib/site.go
@@ -44,6 +44,7 @@ import (
"github.com/gohugoio/hugo/config"
"github.com/gohugoio/hugo/media"
+ "github.com/gohugoio/hugo/parser/metadecoders"
"github.com/markbates/inflect"
@@ -53,7 +54,6 @@ import (
"github.com/gohugoio/hugo/helpers"
"github.com/gohugoio/hugo/hugolib/pagemeta"
"github.com/gohugoio/hugo/output"
- "github.com/gohugoio/hugo/parser"
"github.com/gohugoio/hugo/related"
"github.com/gohugoio/hugo/source"
"github.com/gohugoio/hugo/tpl"
@@ -949,16 +949,8 @@ func (s *Site) readData(f source.ReadableFile) (interface{}, error) {
defer file.Close()
content := helpers.ReaderToBytes(file)
- switch f.Extension() {
- case "yaml", "yml":
- return parser.HandleYAMLData(content)
- case "json":
- return parser.HandleJSONData(content)
- case "toml":
- return parser.HandleTOMLMetaData(content)
- default:
- return nil, fmt.Errorf("Data not supported for extension '%s'", f.Extension())
- }
+ format := metadecoders.FormatFromString(f.Extension())
+ return metadecoders.Unmarshal(content, format)
}
func (s *Site) readDataFromSourceFS() error {
diff --git a/parser/frontmatter.go b/parser/frontmatter.go
index 284d3f955..a42db0cca 100644
--- a/parser/frontmatter.go
+++ b/parser/frontmatter.go
@@ -19,16 +19,12 @@ import (
"bytes"
"encoding/json"
"errors"
- "fmt"
"io"
"strings"
- "github.com/gohugoio/hugo/helpers"
-
- "github.com/spf13/cast"
+ "github.com/gohugoio/hugo/parser/metadecoders"
"github.com/BurntSushi/toml"
- "github.com/chaseadamsio/goorgeous"
"gopkg.in/yaml.v2"
)
@@ -79,6 +75,82 @@ func InterfaceToConfig(in interface{}, mark rune, w io.Writer) error {
}
}
+func InterfaceToConfig2(in interface{}, format metadecoders.Format, w io.Writer) error {
+ if in == nil {
+ return errors.New("input was nil")
+ }
+
+ switch format {
+ case metadecoders.YAML:
+ b, err := yaml.Marshal(in)
+ if err != nil {
+ return err
+ }
+
+ _, err = w.Write(b)
+ return err
+
+ case metadecoders.TOML:
+ return toml.NewEncoder(w).Encode(in)
+ case metadecoders.JSON:
+ b, err := json.MarshalIndent(in, "", " ")
+ if err != nil {
+ return err
+ }
+
+ _, err = w.Write(b)
+ if err != nil {
+ return err
+ }
+
+ _, err = w.Write([]byte{'\n'})
+ return err
+
+ default:
+ return errors.New("Unsupported Format provided")
+ }
+}
+
+func InterfaceToFrontMatter2(in interface{}, format metadecoders.Format, w io.Writer) error {
+ if in == nil {
+ return errors.New("input was nil")
+ }
+
+ switch format {
+ case metadecoders.YAML:
+ _, err := w.Write([]byte(YAMLDelimUnix))
+ if err != nil {
+ return err
+ }
+
+ err = InterfaceToConfig2(in, format, w)
+ if err != nil {
+ return err
+ }
+
+ _, err = w.Write([]byte(YAMLDelimUnix))
+ return err
+
+ case metadecoders.TOML:
+ _, err := w.Write([]byte(TOMLDelimUnix))
+ if err != nil {
+ return err
+ }
+
+ err = InterfaceToConfig2(in, format, w)
+
+ if err != nil {
+ return err
+ }
+
+ _, err = w.Write([]byte("\n" + TOMLDelimUnix))
+ return err
+
+ default:
+ return InterfaceToConfig2(in, format, w)
+ }
+}
+
// InterfaceToFrontMatter encodes a given input into a frontmatter
// representation based upon the mark with the appropriate front matter delimiters
// surrounding the output, which is written to w.
@@ -155,34 +227,6 @@ func FormatSanitize(kind string) string {
}
}
-// DetectFrontMatter detects the type of frontmatter analysing its first character.
-func DetectFrontMatter(mark rune) (f *FrontmatterType) {
- switch mark {
- case '-':
- return &FrontmatterType{HandleYAMLMetaData, []byte(YAMLDelim), []byte(YAMLDelim), false}
- case '+':
- return &FrontmatterType{HandleTOMLMetaData, []byte(TOMLDelim), []byte(TOMLDelim), false}
- case '{':
- return &FrontmatterType{HandleJSONMetaData, []byte{'{'}, []byte{'}'}, true}
- case '#':
- return &FrontmatterType{HandleOrgMetaData, []byte("#+"), []byte("\n"), false}
- default:
- return nil
- }
-}
-
-// HandleTOMLMetaData unmarshals TOML-encoded datum and returns a Go interface
-// representing the encoded data structure.
-func HandleTOMLMetaData(datum []byte) (map[string]interface{}, error) {
- m := map[string]interface{}{}
- datum = removeTOMLIdentifier(datum)
-
- _, err := toml.Decode(string(datum), &m)
-
- return m, err
-
-}
-
// removeTOMLIdentifier removes, if necessary, beginning and ending TOML
// frontmatter delimiters from a byte slice.
func removeTOMLIdentifier(datum []byte) []byte {
@@ -200,125 +244,3 @@ func removeTOMLIdentifier(datum []byte) []byte {
b = bytes.Trim(b, "\r\n")
return bytes.TrimSuffix(b, []byte(TOMLDelim))
}
-
-// HandleYAMLMetaData unmarshals YAML-encoded datum and returns a Go interface
-// representing the encoded data structure.
-// TODO(bep) 2errors remove these handlers (and hopefully package)
-func HandleYAMLMetaData(datum []byte) (map[string]interface{}, error) {
- m := map[string]interface{}{}
- err := yaml.Unmarshal(datum, &m)
-
- // To support boolean keys, the `yaml` package unmarshals maps to
- // map[interface{}]interface{}. Here we recurse through the result
- // and change all maps to map[string]interface{} like we would've
- // gotten from `json`.
- if err == nil {
- for k, v := range m {
- if vv, changed := stringifyMapKeys(v); changed {
- m[k] = vv
- }
- }
- }
-
- return m, err
-}
-
-// HandleYAMLData unmarshals YAML-encoded datum and returns a Go interface
-// representing the encoded data structure.
-func HandleYAMLData(datum []byte) (interface{}, error) {
- var m interface{}
- err := yaml.Unmarshal(datum, &m)
- if err != nil {
- return nil, err
- }
-
- // To support boolean keys, the `yaml` package unmarshals maps to
- // map[interface{}]interface{}. Here we recurse through the result
- // and change all maps to map[string]interface{} like we would've
- // gotten from `json`.
- if mm, changed := stringifyMapKeys(m); changed {
- return mm, nil
- }
-
- return m, nil
-}
-
-// stringifyMapKeys recurses into in and changes all instances of
-// map[interface{}]interface{} to map[string]interface{}. This is useful to
-// work around the impedence mismatch between JSON and YAML unmarshaling that's
-// described here: https://github.com/go-yaml/yaml/issues/139
-//
-// Inspired by https://github.com/stripe/stripe-mock, MIT licensed
-func stringifyMapKeys(in interface{}) (interface{}, bool) {
- switch in := in.(type) {
- case []interface{}:
- for i, v := range in {
- if vv, replaced := stringifyMapKeys(v); replaced {
- in[i] = vv
- }
- }
- case map[interface{}]interface{}:
- res := make(map[string]interface{})
- var (
- ok bool
- err error
- )
- for k, v := range in {
- var ks string
-
- if ks, ok = k.(string); !ok {
- ks, err = cast.ToStringE(k)
- if err != nil {
- ks = fmt.Sprintf("%v", k)
- }
- // TODO(bep) added in Hugo 0.37, remove some time in the future.
- helpers.DistinctFeedbackLog.Printf("WARNING: YAML data/frontmatter with keys of type %T is since Hugo 0.37 converted to strings", k)
- }
- if vv, replaced := stringifyMapKeys(v); replaced {
- res[ks] = vv
- } else {
- res[ks] = v
- }
- }
- return res, true
- }
-
- return nil, false
-}
-
-// HandleJSONMetaData unmarshals JSON-encoded datum and returns a Go interface
-// representing the encoded data structure.
-func HandleJSONMetaData(datum []byte) (map[string]interface{}, error) {
- m := make(map[string]interface{})
-
- if datum == nil {
- // Package json returns on error on nil input.
- // Return an empty map to be consistent with our other supported
- // formats.
- return m, nil
- }
-
- err := json.Unmarshal(datum, &m)
- return m, err
-}
-
-// HandleJSONData unmarshals JSON-encoded datum and returns a Go interface
-// representing the encoded data structure.
-func HandleJSONData(datum []byte) (interface{}, error) {
- if datum == nil {
- // Package json returns on error on nil input.
- // Return an empty map to be consistent with our other supported
- // formats.
- return make(map[string]interface{}), nil
- }
-
- var f interface{}
- err := json.Unmarshal(datum, &f)
- return f, err
-}
-
-// HandleOrgMetaData unmarshals org-mode encoded datum and returns a Go
-// interface representing the encoded data structure.
-func HandleOrgMetaData(datum []byte) (map[string]interface{}, error) {
- return goorgeous.OrgHeaders(datum)
-}
diff --git a/parser/frontmatter_test.go b/parser/frontmatter_test.go
index 7281ca336..d6e6e79c3 100644
--- a/parser/frontmatter_test.go
+++ b/parser/frontmatter_test.go
@@ -132,116 +132,6 @@ func TestInterfaceToFrontMatter(t *testing.T) {
}
}
-func TestHandleTOMLMetaData(t *testing.T) {
- cases := []struct {
- input []byte
- want interface{}
- isErr bool
- }{
- {nil, map[string]interface{}{}, false},
- {[]byte("title = \"test 1\""), map[string]interface{}{"title": "test 1"}, false},
- {[]byte("a = [1, 2, 3]"), map[string]interface{}{"a": []interface{}{int64(1), int64(2), int64(3)}}, false},
- {[]byte("b = [\n[1, 2],\n[3, 4]\n]"), map[string]interface{}{"b": []interface{}{[]interface{}{int64(1), int64(2)}, []interface{}{int64(3), int64(4)}}}, false},
- // errors
- {[]byte("z = [\n[1, 2]\n[3, 4]\n]"), nil, true},
- }
-
- for i, c := range cases {
- res, err := HandleTOMLMetaData(c.input)
- if err != nil {
- if c.isErr {
- continue
- }
- t.Fatalf("[%d] unexpected error value: %v", i, err)
- }
-
- if !reflect.DeepEqual(res, c.want) {
- t.Errorf("[%d] not equal: given %q\nwant %#v,\n got %#v", i, c.input, c.want, res)
- }
- }
-}
-
-func TestHandleYAMLMetaData(t *testing.T) {
- cases := []struct {
- input []byte
- want interface{}
- isErr bool
- }{
- {nil, map[string]interface{}{}, false},
- {[]byte("title: test 1"), map[string]interface{}{"title": "test 1"}, false},
- {[]byte("a: Easy!\nb:\n c: 2\n d: [3, 4]"), map[string]interface{}{"a": "Easy!", "b": map[string]interface{}{"c": 2, "d": []interface{}{3, 4}}}, false},
- {[]byte("a:\n true: 1\n false: 2"), map[string]interface{}{"a": map[string]interface{}{"true": 1, "false": 2}}, false},
- // errors
- {[]byte("z = not toml"), nil, true},
- }
-
- for i, c := range cases {
- res, err := HandleYAMLMetaData(c.input)
- if err != nil {
- if c.isErr {
- continue
- }
- t.Fatalf("[%d] unexpected error value: %v", i, err)
- }
-
- if !reflect.DeepEqual(res, c.want) {
- t.Errorf("[%d] not equal: given %q\nwant %#v,\n got %#v", i, c.input, c.want, res)
- }
- }
-}
-
-func TestHandleJSONMetaData(t *testing.T) {
- cases := []struct {
- input []byte
- want interface{}
- isErr bool
- }{
- {nil, map[string]interface{}{}, false},
- {[]byte("{\"title\": \"test 1\"}"), map[string]interface{}{"title": "test 1"}, false},
- // errors
- {[]byte("{noquotes}"), nil, true},
- }
-
- for i, c := range cases {
- res, err := HandleJSONMetaData(c.input)
- if err != nil {
- if c.isErr {
- continue
- }
- t.Fatalf("[%d] unexpected error value: %v", i, err)
- }
-
- if !reflect.DeepEqual(res, c.want) {
- t.Errorf("[%d] not equal: given %q\nwant %#v,\n got %#v", i, c.input, c.want, res)
- }
- }
-}
-
-func TestHandleOrgMetaData(t *testing.T) {
- cases := []struct {
- input []byte
- want interface{}
- isErr bool
- }{
- {nil, map[string]interface{}{}, false},
- {[]byte("#+title: test 1\n"), map[string]interface{}{"title": "test 1"}, false},
- }
-
- for i, c := range cases {
- res, err := HandleOrgMetaData(c.input)
- if err != nil {
- if c.isErr {
- continue
- }
- t.Fatalf("[%d] unexpected error value: %v", i, err)
- }
-
- if !reflect.DeepEqual(res, c.want) {
- t.Errorf("[%d] not equal: given %q\nwant %#v,\n got %#v", i, c.input, c.want, res)
- }
- }
-}
-
func TestFormatToLeadRune(t *testing.T) {
for i, this := range []struct {
kind string
@@ -264,41 +154,6 @@ func TestFormatToLeadRune(t *testing.T) {
}
}
-func TestDetectFrontMatter(t *testing.T) {
- cases := []struct {
- mark rune
- want *FrontmatterType
- }{
- // funcs are uncomparable, so we ignore FrontmatterType.Parse in these tests
- {'-', &FrontmatterType{nil, []byte(YAMLDelim), []byte(YAMLDelim), false}},
- {'+', &FrontmatterType{nil, []byte(TOMLDelim), []byte(TOMLDelim), false}},
- {'{', &FrontmatterType{nil, []byte("{"), []byte("}"), true}},
- {'#', &FrontmatterType{nil, []byte("#+"), []byte("\n"), false}},
- {'$', nil},
- }
-
- for _, c := range cases {
- res := DetectFrontMatter(c.mark)
- if res == nil {
- if c.want == nil {
- continue
- }
-
- t.Fatalf("want %v, got %v", *c.want, res)
- }
-
- if !reflect.DeepEqual(res.markstart, c.want.markstart) {
- t.Errorf("markstart mismatch: want %v, got %v", c.want.markstart, res.markstart)
- }