diff options
author | Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> | 2022-05-02 16:07:52 +0200 |
---|---|---|
committer | Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com> | 2022-05-06 19:43:22 +0200 |
commit | f2946da9e806c2bafbdd26707fe339db79bd980b (patch) | |
tree | b5609317a861ea5f399e094e1b9287ca71dc22d1 /tpl/transform | |
parent | 6eea32bd6bc8e7a7dd07a8cb6a8343ae2c74aba0 (diff) |
Improve error messages, esp. when the server is running
* Add file context to minifier errors when publishing
* Misc fixes (see issues)
* Allow custom server error template in layouts/server/error.html
To get to this, this commit also cleans up and simplifies the code surrounding errors and files. This also removes the usage of `github.com/pkg/errors`, mostly because of https://github.com/pkg/errors/issues/223 -- but also because most of this is now built-in to Go.
Fixes #9852
Fixes #9857
Fixes #9863
Diffstat (limited to 'tpl/transform')
-rw-r--r-- | tpl/transform/remarshal.go | 2 | ||||
-rw-r--r-- | tpl/transform/unmarshal.go | 12 |
2 files changed, 8 insertions, 6 deletions
diff --git a/tpl/transform/remarshal.go b/tpl/transform/remarshal.go index b5d682144..0ad54bb96 100644 --- a/tpl/transform/remarshal.go +++ b/tpl/transform/remarshal.go @@ -4,7 +4,7 @@ import ( "bytes" "strings" - "github.com/pkg/errors" + "errors" "github.com/gohugoio/hugo/parser" "github.com/gohugoio/hugo/parser/metadecoders" diff --git a/tpl/transform/unmarshal.go b/tpl/transform/unmarshal.go index 62682557c..340235fa4 100644 --- a/tpl/transform/unmarshal.go +++ b/tpl/transform/unmarshal.go @@ -14,6 +14,7 @@ package transform import ( + "fmt" "io/ioutil" "strings" @@ -23,9 +24,10 @@ import ( "github.com/mitchellh/mapstructure" + "errors" + "github.com/gohugoio/hugo/helpers" "github.com/gohugoio/hugo/parser/metadecoders" - "github.com/pkg/errors" "github.com/spf13/cast" ) @@ -54,7 +56,7 @@ func (ns *Namespace) Unmarshal(args ...any) (any, error) { data = args[1] decoder, err = decodeDecoder(m) if err != nil { - return nil, errors.WithMessage(err, "failed to decode options") + return nil, fmt.Errorf("failed to decode options: %w", err) } } @@ -72,7 +74,7 @@ func (ns *Namespace) Unmarshal(args ...any) (any, error) { return ns.cache.GetOrCreate(key, func() (any, error) { f := metadecoders.FormatFromMediaType(r.MediaType()) if f == "" { - return nil, errors.Errorf("MIME %q not supported", r.MediaType()) + return nil, fmt.Errorf("MIME %q not supported", r.MediaType()) } reader, err := r.ReadSeekCloser() @@ -92,7 +94,7 @@ func (ns *Namespace) Unmarshal(args ...any) (any, error) { dataStr, err := types.ToStringE(data) if err != nil { - return nil, errors.Errorf("type %T not supported", data) + return nil, fmt.Errorf("type %T not supported", data) } if dataStr == "" { @@ -160,7 +162,7 @@ func stringToRune(v any) (rune, error) { if i == 0 { r = rr } else { - return 0, errors.Errorf("invalid character: %q", v) + return 0, fmt.Errorf("invalid character: %q", v) } } |