diff options
author | Andreas Deininger <andreas@deininger.net> | 2023-05-22 18:14:10 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-22 18:14:10 +0200 |
commit | 9a0370e8eb71fed3ac04984020b6aa95c43f22ab (patch) | |
tree | 031150a69c18dc216321e716abcb506e10616428 /resources | |
parent | 10d0fcc01f77b1edad16fbdd415825731f7419fb (diff) |
postcss: Improve validation of option 'config'
Diffstat (limited to 'resources')
-rw-r--r-- | resources/resource_transformers/babel/babel.go | 8 | ||||
-rw-r--r-- | resources/resource_transformers/postcss/postcss.go | 8 |
2 files changed, 12 insertions, 4 deletions
diff --git a/resources/resource_transformers/babel/babel.go b/resources/resource_transformers/babel/babel.go index ff19d9dda..5ed09d200 100644 --- a/resources/resource_transformers/babel/babel.go +++ b/resources/resource_transformers/babel/babel.go @@ -134,13 +134,17 @@ func (t *babelTransformation) Transform(ctx *resources.ResourceTransformationCtx } configFile = filepath.Clean(configFile) + isConfigFileDir := false // We need an absolute filename to the config file. if !filepath.IsAbs(configFile) { - configFile = t.rs.BaseFs.ResolveJSConfigFile(configFile) + configFile, isConfigFileDir = t.rs.BaseFs.ResolveJSConfigFile(configFile) + if isConfigFileDir { + logger.Warnf("babel config %q must be a file, not a directory", configFile) + } if configFile == "" && t.options.Config != "" { // Only fail if the user specified config file is not found. - return fmt.Errorf("babel config %q not found:", configFile) + return fmt.Errorf("babel config file %q not found", configFile) } } diff --git a/resources/resource_transformers/postcss/postcss.go b/resources/resource_transformers/postcss/postcss.go index 376d72182..ee3f39be1 100644 --- a/resources/resource_transformers/postcss/postcss.go +++ b/resources/resource_transformers/postcss/postcss.go @@ -172,13 +172,17 @@ func (t *postcssTransformation) Transform(ctx *resources.ResourceTransformationC } configFile = filepath.Clean(configFile) + isConfigFileDir := false // We need an absolute filename to the config file. if !filepath.IsAbs(configFile) { - configFile = t.rs.BaseFs.ResolveJSConfigFile(configFile) + configFile, isConfigFileDir = t.rs.BaseFs.ResolveJSConfigFile(configFile) if configFile == "" && options.Config != "" { // Only fail if the user specified config file is not found. - return fmt.Errorf("postcss config %q not found:", options.Config) + return fmt.Errorf("postcss config directory %q not found", options.Config) + } + if !isConfigFileDir { + logger.Warnf("postcss config %q must be a directory", options.Config) } } |